Create FluentUI_common
module, part 1
#2094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This is part 1 of creating a new
FluentUI_common
module to shareFluentTheme
(and others) between iOS and macOS. The goal of this PR is to rework several files and interfaces in ways that will directly contribute towards the goal of moving this important logic out of the module.Some highlights of the changes:
public
so theFluentUI_ios
module can consume them out ofFluentUI_common
. For example, much ofControlTokenSet
.TokenizedControlInternal
interface. It's been fully folded intoTokenizedControl
.DynamicColor
has been reduced further in importance, and now largely exists only to have something to conform toShapeStyle
for iOS 17.isApplicableThemeChange()
onto aUIView
extension. This will make it possible to share theme changing logic in the future by creating an equivalentNSView
extension.Binary change
Still working on new system, but when comparing Archive output of the release iOS app:
Verification
Key scenario validation pass across iOS demo app.
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow