Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y][VoiceOver] Set accessibility value for the sheet expansion state #2101

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

nodes11
Copy link
Contributor

@nodes11 nodes11 commented Oct 31, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Currently, the resizing handle of the bottom sheet does not read its current state (i.e. "Collapsed" or "Expanded"). This change adds that functionality to align with Apple system sheets and improve the VoiceOver experience.

I updateResizingHandleViewAccessibility to set the accessibilityValue on the resizingHandle based on the provided expansion state. Updated where updateResizingHandleViewAccessibility is called to ensure that the accessibility values are updated before the voiceover reads the new state.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

On iPhone, in the Fluent Test app, I validated that the "Expanded" value is read when the sheet is in an expanded state and that the "Collapsed" value is read when the sheet is in a collapsed state.

After:
RPReplay_Final1730406726.MP4

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11 nodes11 requested a review from a team as a code owner October 31, 2024 20:33
@joannaquu
Copy link
Contributor

can you just call updateResizingHandleViewAccessibility in move(...)? or is the issue still that the value is wrong

@nodes11 nodes11 merged commit a4abfdb into microsoft:main Nov 5, 2024
7 checks passed
@joannaquu joannaquu mentioned this pull request Nov 21, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants