Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swift 6 error #2103

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Fix swift 6 error #2103

merged 1 commit into from
Nov 2, 2024

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Nov 1, 2024 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

In swift 6, it's an error to use Combine.ObservableObject and not import Combine. Explicitly import it.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner November 1, 2024 22:42
@joannaquu joannaquu enabled auto-merge (squash) November 2, 2024 00:05
@joannaquu joannaquu merged commit dbc5609 into microsoft:main Nov 2, 2024
7 checks passed
@joannaquu joannaquu deleted the joannaqu/swift-6 branch November 2, 2024 03:46
@joannaquu joannaquu mentioned this pull request Nov 21, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrajeswaran anandrajeswaran anandrajeswaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joannaquu @anandrajeswaran