Don't recreate pill buttons when the pill button bar's bounds change

[laminesm]

Platforms Impacted

• iOS
• visionOS
• macOS

Description of changes

Recreating the pill buttons when the bounds property of the bar changes can lead to inconsistent frame calculations during layout passes. For instance, there's a use case where accessing the width of the bar's contentSize in viewDidLayoutSubviews or viewWillTransitionToSize returns 0 because the buttons are removed and being re-added during the layout pass. From the comment it's still unclear why this logic exists. With the help of #mischreiber, we think it's best to remove this logic altogether and find a less fragile fix if it breaks edge cases we're not aware of.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Tested the Pill Button Bar on the demo app and on the client app use case. No regressions were observed even though large text mode support on the control is broken independent of this change.

Visual Verification

Before	After

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow