Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand sheet string #2111

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Expand sheet string #2111

merged 2 commits into from
Dec 30, 2024

Conversation

nodes11
Copy link
Contributor

@nodes11 nodes11 commented Dec 30, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

We have an internal request to use a more verbose string for the bottom sheet controller resizing handle accessibility label so that the user knows what is being expanded or collapsed.

Previously, the accessibility label would just read "Expand" or "Collapse". Now the accessibility label will read "Expand Sheet" or "Collapse Sheet".

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

  • On iPhone, validated that new strings are used when VoiceOver is ON.
  • Using simulator and Accessibility Inspector, validated that the accessibility label is set as expected.
Visual Verification
Before After

|
Screenshot 2024-12-30 at 9 09 09 AM
|
Screenshot 2024-12-30 at 9 09 27 AM
|

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11 nodes11 requested a review from a team as a code owner December 30, 2024 17:30
@nodes11 nodes11 merged commit 33e8f2e into microsoft:main Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants