Added large custom view size to MSFTableViewCell

[nabil-k]

Platforms Impacted

• iOS
• visionOS
• macOS

Description of changes

• Added a large custom view size option MSFTableViewCell to accommodate larger custom views.
• TableViewCell.swift
  • Forcing two line layout when using the new large size if the layout type was trying to be one line.
• Added the large custom view size example to the demo app

Binary change

N/A

Verification

When using a fluent avatar with size 40 and then setting an activity, for example:

let avatar = MSFAvatar(style: .default, size: .size40)
avatar.state.activityStyle = .circle
avatar.state.activityImage = UIImage(systemName: "star")
avatar.state.image = UIImage(systemName: "person")

The avatar view will actually go from having 40x40 dimensions, to having 46x46 dimensions. When using the fluent table view cell which can only accommodate 40x40, this causes the unread status to make contact with the custom view. However, when using the new large custom view, that is no longer the case.

Before (Using medium custom view size)	After (using new large custom view size)

Before (Not forcing two line layout for large custom view size)	After (forcing two line layout for large custom view size)

Large custom view size added to testapp:

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

[joannaquu]

have we run this pass design yet?

[nabil-k]

Haven't followed up with any designers about this regarding fluent specifically.

[anandrajeswaran]

Is the issue really that we need a new size? Or is it just a layout (implementation) issue at an existing size?

[nabil-k]

Followed up with @joannaquu offline and reaching out to designers. Will provide an update when I hear back.

@anandrajeswaran I think the issue is that we'd need a new size. From that I've seen in a design the avatars with activities are supposed to be 46x46. But I'll pass this question along with design and see what they say about if the adjustment that needs to be made is related to the table view cell or the avatar.

[nabil-k]

Spoke with design and they were okay with this change. They didn't have any opinions though on if the change should be made to the avatar v.s. the table cell.

[anandrajeswaran]

Followed up with @joannaquu offline and reaching out to designers. Will provide an update when I hear back.

@anandrajeswaran I think the issue is that we'd need a new size. From that I've seen in a design the avatars with activities are supposed to be 46x46. But I'll pass this question along with design and see what they say about if the adjustment that needs to be made is related to the table view cell or the avatar.

Can you add an example in the Demo app? May be interesting to show how this looks relative to other similarly sized cells and what impact that has on consuming code

[nabil-k]

@microsoft-github-policy-service agree company="Microsoft"

[joannaquu]

sorry, just thought of one more thing to check. MSFTableViewCellCustomViewSize should be used in ListItem, as well PersonaCell, PopupMenuCell. can you double check that this change does not affect them?

[nabil-k]

Checked with those controls and didn't see they'd be affected. But I'm going to close this PR since I was able to get the same results by just overriding the tokens for the custom view. So this PRs changes don't need to be checked in.