Remove restrictions on legend width #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MulyukovAidar
added a commit
that referenced
this pull request
May 30, 2024
* Create build.yml * Dev vdnursultan feature (#302) * added toggle for disabling rectangle roundness * renamed setting * version up * Update build.yml updated to run older gantt * Dev vdnursultan feature (#303) * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json * Update build.yml * Create codeql.yml * New translations * New translations * V3.0.0 (#314) * Issue 38630: options state comparison added * Issue 38630: new compare function created * npm packages update & deprecated deletion * playwright added * eslint added * travis.yml file removed * d3 packages added, updated in files * lodash added, files updated * core-js require removed * eslint errors and warnings fix * karma.conf and test.webpack.config fix * version updates in files, capabilities and less file fix * renderTooltip method fix * clearCatcher opacity configured in style * behavior fix * lodash restore - render fix * Formatting models update * context menu configured * supportsHighlights feature added * code refactoring * packages update * taskCollapse comparison removed * label naming fix in formatting models * audit fix * tests global fix * merge * code refactoring * durationMin min value fix * less file fix * Add collapseTasksUpdateId to formatting settings * nullable and undefined value errors fix * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json * Rounded Rectangle feature toggle complete: Merge dev into certification (#304) * added toggle for disabling rectangle roundness * Create build.yml * renamed setting * version up * Dev vdnursultan feature (#302) * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json * Update build.yml updated to run older gantt * Dev vdnursultan feature (#303) * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json --------- Co-authored-by: MulyukovAidar <v-aimulyukov@microsoft.com> * Rounded corners now affects tasks and day offs * npm packages update * static functions restored * visualBuilder lint fix and highlight typo fix in visualData * ts-node package removed * hasOwnProperty call replaced with in operator * hasHighlight calculation refactor * gantt roles calculation refactor * equality operator fixed * ganttDiv scroll event handler referring this fix * modifying variables and methods to static type * updateInternal method part is separated to render method * tools version upgraded * use node16 and fix for error:03000086:digital * use node18 * fix error:03000086:digital in test step in build.yml * node 12, build status from github action * node 14 * node 16 * node 10 * node16 + fix test error * flag moved to karma conf * ubuntu 20.04 * remove redundant settings * azure pipelines removed * context menu moved to behavior * redundant lodash usages fixed, some methods replaced with in-built javascript functions * version up, feature complete * dependencies update * formattingModels update * Update README.md * Add GitHub Actions pipeline to test code * Remove tslint.json * Fix persisting collapsed tasks * Update packages * Move enums to dedicated files. Refactor methods to use enums instead of strings * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Move all enums to enums.ts * Make "Collapse All", "Expand All" clickable instead of only the arrow * fix eslint error: Remove 2015 ES module declaration * Update build.yml * Fix build.yml to use ubuntu-20.04 * Refactor "createTasks" method and fix eslint errors * Fix test that checks if elements are highlighted In DataViewValueColumn highlights array represents elements which should be highlighted. The bug was that highlights array was randomly generated with values greater than actual values. Fix broken test --------- Co-authored-by: Rustam Boranov <v-rboranov@microsoft.com> Co-authored-by: v-ruboranov <v-ruboranov@microsoft.com> Co-authored-by: Nursultan Dzhumabaev <nurzamazkatanks@gmail.com> Co-authored-by: Nursultan Dzhumabaev <v-dnursultan@microsoft.com> Co-authored-by: MulyukovAidar <v-aimulyukov@microsoft.com> * Fix bugs (#320) * Fix: force rounded corners of bars when "barsRoundedCorners" is enabled. Previously, rounded corners were disabled when bar is too narrow. * Fix: remove redundant "Show" button in "Legend" card * Fix: remove "collapse all arrow" when category labels are disabled * Fix: put data labels in the center when "position" is set to "Inside" * Fix: axis is cut off when "Date Type" is set to "Hour". Add outer padding to fix. * Fix eslint error * Update API to 5.8.0 * Fix tests regarding task position Adding toggle to control rounded corners broke the tests. * Replace 'playwright' with 'playwright-chromium' * New translations * Fix legend labels and show `collapse/expand` buttons when "category labels" is disabled (#323) * Fix populating legend fill colors * Show "Collapse All", "Expand All" buttons even when "Category labels" is disabled * Fix tests with label name * Bump version to 3.0.2 (#324) * Render "Collapse all" / "Expand all" even if "Category labels" is disabled (#325) * Fix issue when milestones were rendered twice (#327) * Show "Legend name" in tooltips * Fix issue where milestones were rendered twice * Add localization keys for "Expand All", "Collapse All" buttons * Update packages * Enable multi selection with metaKey for legends and tasks * Add comments * Fix disappearing bars bug (#332) * Fix: show context menu when right-clicking on empty place inside visual * Fix rendering task with milestones * Fix issue: bars are shifted when "rounded corners" settings is enabled * Bump version to 3.0.5.0 * Fix tests regarding task position * Remove redundant behavior option * Return old UI appearance - task bars will be shifted to the left (#333) * Return old UI appearance - task bars will be shifted to the left a little I decided not to change UI for old reports, because we didn't get complaints about shifted task bars * Update chartutils to 6.0.3 * Fix context menu, do not show multiple context menus (#335) * New translations * New translations * Fix axis position compared to tasks position (#339) * Fix axis position compared to tasks position * Increase axis and tasks padding so axis is visible when "Date type" is set to "Hour" * Remove magic numbers * Upgrade API to 5.9.0 * When tasks are small drawing them as rounded makes them look awful. (#341) Fix axis position compared to tasks position * Remove restrictions on legend width (#344) * Remove restrictions on legend width * Update CHANGELOG.md --------- Co-authored-by: Nursultan Dzhumabaev <v-dnursultan@microsoft.com> Co-authored-by: Nikita Grachev <v-grniki@microsoft.com> Co-authored-by: pbicvloc <104190707+pbicvloc@users.noreply.github.com> Co-authored-by: adiletelf <74559101+adiletelf@users.noreply.github.com> Co-authored-by: Rustam Boranov <v-rboranov@microsoft.com> Co-authored-by: v-ruboranov <v-ruboranov@microsoft.com> Co-authored-by: Nursultan Dzhumabaev <nurzamazkatanks@gmail.com>
MulyukovAidar
added a commit
that referenced
this pull request
Jun 3, 2024
* Create build.yml * Dev vdnursultan feature (#302) * added toggle for disabling rectangle roundness * renamed setting * version up * Update build.yml updated to run older gantt * Dev vdnursultan feature (#303) * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json * Update build.yml * Create codeql.yml * New translations * New translations * V3.0.0 (#314) * Issue 38630: options state comparison added * Issue 38630: new compare function created * npm packages update & deprecated deletion * playwright added * eslint added * travis.yml file removed * d3 packages added, updated in files * lodash added, files updated * core-js require removed * eslint errors and warnings fix * karma.conf and test.webpack.config fix * version updates in files, capabilities and less file fix * renderTooltip method fix * clearCatcher opacity configured in style * behavior fix * lodash restore - render fix * Formatting models update * context menu configured * supportsHighlights feature added * code refactoring * packages update * taskCollapse comparison removed * label naming fix in formatting models * audit fix * tests global fix * merge * code refactoring * durationMin min value fix * less file fix * Add collapseTasksUpdateId to formatting settings * nullable and undefined value errors fix * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json * Rounded Rectangle feature toggle complete: Merge dev into certification (#304) * added toggle for disabling rectangle roundness * Create build.yml * renamed setting * version up * Dev vdnursultan feature (#302) * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json * Update build.yml updated to run older gantt * Dev vdnursultan feature (#303) * added toggle for disabling rectangle roundness * renamed setting * version up * hotFix: renamed property in capabilities.json * hotfix: renamed property in capabilities.json --------- Co-authored-by: MulyukovAidar <v-aimulyukov@microsoft.com> * Rounded corners now affects tasks and day offs * npm packages update * static functions restored * visualBuilder lint fix and highlight typo fix in visualData * ts-node package removed * hasOwnProperty call replaced with in operator * hasHighlight calculation refactor * gantt roles calculation refactor * equality operator fixed * ganttDiv scroll event handler referring this fix * modifying variables and methods to static type * updateInternal method part is separated to render method * tools version upgraded * use node16 and fix for error:03000086:digital * use node18 * fix error:03000086:digital in test step in build.yml * node 12, build status from github action * node 14 * node 16 * node 10 * node16 + fix test error * flag moved to karma conf * ubuntu 20.04 * remove redundant settings * azure pipelines removed * context menu moved to behavior * redundant lodash usages fixed, some methods replaced with in-built javascript functions * version up, feature complete * dependencies update * formattingModels update * Update README.md * Add GitHub Actions pipeline to test code * Remove tslint.json * Fix persisting collapsed tasks * Update packages * Move enums to dedicated files. Refactor methods to use enums instead of strings * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Move all enums to enums.ts * Make "Collapse All", "Expand All" clickable instead of only the arrow * fix eslint error: Remove 2015 ES module declaration * Update build.yml * Fix build.yml to use ubuntu-20.04 * Refactor "createTasks" method and fix eslint errors * Fix test that checks if elements are highlighted In DataViewValueColumn highlights array represents elements which should be highlighted. The bug was that highlights array was randomly generated with values greater than actual values. Fix broken test --------- Co-authored-by: Rustam Boranov <v-rboranov@microsoft.com> Co-authored-by: v-ruboranov <v-ruboranov@microsoft.com> Co-authored-by: Nursultan Dzhumabaev <nurzamazkatanks@gmail.com> Co-authored-by: Nursultan Dzhumabaev <v-dnursultan@microsoft.com> Co-authored-by: MulyukovAidar <v-aimulyukov@microsoft.com> * Fix bugs (#320) * Fix: force rounded corners of bars when "barsRoundedCorners" is enabled. Previously, rounded corners were disabled when bar is too narrow. * Fix: remove redundant "Show" button in "Legend" card * Fix: remove "collapse all arrow" when category labels are disabled * Fix: put data labels in the center when "position" is set to "Inside" * Fix: axis is cut off when "Date Type" is set to "Hour". Add outer padding to fix. * Fix eslint error * Update API to 5.8.0 * Fix tests regarding task position Adding toggle to control rounded corners broke the tests. * Replace 'playwright' with 'playwright-chromium' * New translations * Fix legend labels and show `collapse/expand` buttons when "category labels" is disabled (#323) * Fix populating legend fill colors * Show "Collapse All", "Expand All" buttons even when "Category labels" is disabled * Fix tests with label name * Bump version to 3.0.2 (#324) * Render "Collapse all" / "Expand all" even if "Category labels" is disabled (#325) * Fix issue when milestones were rendered twice (#327) * Show "Legend name" in tooltips * Fix issue where milestones were rendered twice * Add localization keys for "Expand All", "Collapse All" buttons * Update packages * Enable multi selection with metaKey for legends and tasks * Add comments * Fix disappearing bars bug (#332) * Fix: show context menu when right-clicking on empty place inside visual * Fix rendering task with milestones * Fix issue: bars are shifted when "rounded corners" settings is enabled * Bump version to 3.0.5.0 * Fix tests regarding task position * Remove redundant behavior option * Return old UI appearance - task bars will be shifted to the left (#333) * Return old UI appearance - task bars will be shifted to the left a little I decided not to change UI for old reports, because we didn't get complaints about shifted task bars * Update chartutils to 6.0.3 * Fix context menu, do not show multiple context menus (#335) * New translations * New translations * Fix axis position compared to tasks position (#339) * Fix axis position compared to tasks position * Increase axis and tasks padding so axis is visible when "Date type" is set to "Hour" * Remove magic numbers * Upgrade API to 5.9.0 * When tasks are small drawing them as rounded makes them look awful. (#341) Fix axis position compared to tasks position * Remove restrictions on legend width (#344) * Remove restrictions on legend width * Update CHANGELOG.md --------- Co-authored-by: Nursultan Dzhumabaev <v-dnursultan@microsoft.com> Co-authored-by: Nikita Grachev <v-grniki@microsoft.com> Co-authored-by: pbicvloc <104190707+pbicvloc@users.noreply.github.com> Co-authored-by: adiletelf <74559101+adiletelf@users.noreply.github.com> Co-authored-by: Rustam Boranov <v-rboranov@microsoft.com> Co-authored-by: v-ruboranov <v-ruboranov@microsoft.com> Co-authored-by: Nursultan Dzhumabaev <nurzamazkatanks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.