Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts/vcpkg_install_make] Keep LOGFILE_ROOT undefined since CMake 3.31.0 #43165

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Jan 8, 2025

Fix #43163, cmake_parse_arguments(PARSE_ARGV) processed arg_LOGFILE_ROOT become empty string rather than undefined since CMake 3.31

Remove the empty string LOGFILE_ROOT in vcpkg_install_make.cmake to keep arg_LOGFILE_ROOT undefined.

There is no empty string LOGFILE_ROOT argument call in other functions.

Related

Reference

See https://cmake.org/cmake/help/v3.31/policy/CMP0174.html

Prior to CMake 3.31, no variable would be defined if the value given after a single-value keyword was an empty string.

For the NEW behavior, cmake_parse_arguments(PARSE_ARGV) always defines a variable for each keyword given in the arguments, even a single-value keyword with an empty string as its value or no value at all.

Test

Example port libcsv installation tests pass with the following triplets:

  • x64-linux (CMake 3.30.1 and CMake 3.31.3)
  • x64-windows (CMake 3.30.1 and CMake 3.31.3)

@WangWeiLin-MV WangWeiLin-MV added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jan 8, 2025
@WangWeiLin-MV WangWeiLin-MV changed the title [scripts/vcpkg_install_make] Keep LOGFILE_ROOT undefined [scripts/vcpkg_install_make] Keep LOGFILE_ROOT undefined since CMake 3.31.0 Jan 8, 2025
@WangWeiLin-MV WangWeiLin-MV added the info:internal This PR or Issue was filed by the vcpkg team. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg_build_make has empty logfile prefix with newer versions of CMake
2 participants