Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: Add GitHub service connection parameter for npm release template #1870

Merged
merged 2 commits into from
Jan 13, 2025
Merged

pipelines: Add GitHub service connection parameter for npm release template #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39260a
pipelines: Add GitHub service connection parameter for npm release te…
alexweininger Jan 13, 2025
ed23108
Update readme
bwateratmsft Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion azure-pipelines/1es-release-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ parameters:
displayName: Approver Alias
type: string

- name: GitHubServiceConnection
displayName: GitHub Service Connection
type: string
default: GitHub-AzureTools

# `resources` specifies the location of templates to pick up, use it to get 1ES templates
resources:
repositories:
Expand Down Expand Up @@ -135,7 +140,7 @@ extends:
displayName: "\U0001F449 GitHub release (create)"
condition: and(succeeded(), ${{ eq(parameters.dryRun, false) }})
inputs:
gitHubConnection: "GitHub-AzureTools"
gitHubConnection: ${{ parameters.GitHubServiceConnection }}
tagSource: userSpecifiedTag
tag: "${{ parameters.PackageToPublish }}-v$(Version)"
title: "${{ parameters.PackageToPublish }} v$(Version)"
Expand Down
4 changes: 2 additions & 2 deletions azure-pipelines/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ resources:
type: github
name: microsoft/vscode-azuretools
ref: main
endpoint: GitHub-AzureTools # The service connection to use when accessing this repository
endpoint: GitHub-AzureTools # CUSTOMIZE: The service connection to use when accessing this repository

parameters:
- name: enableLongRunningTests
Expand Down Expand Up @@ -158,7 +158,7 @@ resources:
type: github
name: microsoft/vscode-azuretools
ref: main
endpoint: GitHub-AzureTools
endpoint: GitHub-AzureTools # CUSTOMIZE - service connection to use when accessing this repository

variables:
# Required by MicroBuild template
Expand Down
Loading