Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Object.connect() to Signal.connect() where applicable #68

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Refactor Object.connect() to Signal.connect() where applicable #68

merged 1 commit into from
Oct 6, 2024

Conversation

yoantran
Copy link
Collaborator

@yoantran yoantran commented Oct 6, 2024

Resolved #47

@yoantran yoantran added feature New feature or request refactor This would make life easier labels Oct 6, 2024
@yoantran yoantran requested a review from miketvo October 6, 2024 08:42
@yoantran yoantran self-assigned this Oct 6, 2024
@miketvo
Copy link
Owner

miketvo commented Oct 6, 2024

LGTM, thank you @yoantran

@miketvo miketvo merged commit 89dba57 into dev Oct 6, 2024
2 checks passed
@miketvo miketvo deleted the refactor/47-signals-syntax branch October 6, 2024 08:54
@miketvo miketvo mentioned this pull request Oct 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketvo miketvo Awaiting requested review from miketvo

Assignees

@yoantran yoantran

Labels
feature New feature or request refactor This would make life easier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoantran @miketvo