Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment and Structure setup #1

Merged
merged 12 commits into from
Nov 12, 2023
Merged

Environment and Structure setup #1

merged 12 commits into from
Nov 12, 2023

Conversation

black7375
Copy link
Contributor

Description

The initial settings and structure of the project.

Related Issue

Changes

  • Package manager
  • Typescript
  • Bundler & Unit Test
  • Lint & Formatter
  • Github CI & Build system
  • Core sample package

Checklist

  • Does it install, build, and type infer well in other environments like Windows?
  • The name and structure of the package is appropriate
  • Rules for things like lint and formatting

Commands:
```
yarn init -2 -w
yarn set version 3.6.4
yarn config set nodeLinker pnpm
yarn plugin import interactive-tools
yarn plugin import https://mskelton.dev/yarn-outdated/v3
```

Currently, Vite don't works with yarn 4
- yarnpkg/berry#5165
commands:
```
yarn add -D typescript @types/node
yarn add tslib
yarn plugin import typescript
```
@black7375 black7375 added the enhancement New feature or request label Nov 8, 2023
- `@mincho-js/core` to `@mincho/css`
- `@mincho-js/transform-to-vanilla` to `@mincho/transform-to-vanilla`
- https://typescript-eslint.io/linting/troubleshooting/#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

Parsing error: ESLint was configured to run on `src/transform-values/simply-important.ts` using `parserOptions.project`:
- <tsconfigRootDir>/tsconfig.json
- <tsconfigRootDir>/tsconfig.node.json
However, none of those TSConfigs include this file. Either:
- Change ESLint's list of included files to not include this file
- Change one of those TSConfigs to include this file
- Create a new TSConfig that includes this file and include it

Prettier rule for windows
- error  Delete ␍  prettier/prettier

Vite Config type
@black7375 black7375 force-pushed the setup branch 5 times, most recently from 5e54e0c to b1764c6 Compare November 11, 2023 17:04
Copy link
Member

@Jeong-jj Jeong-jj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine👍
If i want to fix later, i will tell you, but i think there would be nothing

@black7375
Copy link
Contributor Author

Thanks. Let's merge.

@black7375 black7375 merged commit 5a08411 into main Nov 12, 2023
4 checks passed
@black7375 black7375 deleted the setup branch January 14, 2024 16:23
@black7375 black7375 mentioned this pull request Jul 22, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants