-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #117
Version Packages #117
Conversation
WalkthroughThe pull request involves the removal of a file containing patch declarations for the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Triggered from #117 by @black7375. Checking if we can fast forward Target branch ( commit 9d5f878754e216b21fa233e215b25523c822a9a7 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Sep 30 19:11:31 2024 +0900
Chore: Versioning for PMC S24 Pull request ( commit 3b26c193de8b4a5e4acd651f4d82cf706e01d35b (pull_request/changeset-release/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Sep 30 19:42:10 2024 +0900
Chore: Version Packages It is possible to fast forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
packages/transform-to-vanilla/CHANGELOG.md (1)
3-7
: LGTM! Consider adding more details to the changelog entry.The new changelog entry for version 0.0.3 is correctly structured and consistent with the PR objectives. It properly references the PR, commit, and contributor.
Consider expanding on "Variant features" to provide more context about what was added or changed. This will help users understand the impact of this update more clearly.
For example:
- - [#116](https://github.com/mincho-js/mincho/pull/116) [`9d5f878`](https://github.com/mincho-js/mincho/commit/9d5f878754e216b21fa233e215b25523c822a9a7) Thanks [@black7375](https://github.com/black7375)! - Variant features + - [#116](https://github.com/mincho-js/mincho/pull/116) [`9d5f878`](https://github.com/mincho-js/mincho/commit/9d5f878754e216b21fa233e215b25523c822a9a7) Thanks [@black7375](https://github.com/black7375)! - Added variant features to enhance customization optionspackages/css/CHANGELOG.md (1)
3-10
: LGTM with a minor suggestion for improvement.The changelog entry for version 0.0.4 is structurally sound and follows the established format. It correctly references the PR, commit, and updated dependencies. However, the description "Variant features" could be more informative.
Consider expanding on "Variant features" to provide more context about what specific features were added or modified. This will help users understand the impact of the update more clearly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
- .changeset/moody-otters-shave.md (0 hunks)
- packages/css/CHANGELOG.md (1 hunks)
- packages/css/package.json (1 hunks)
- packages/transform-to-vanilla/CHANGELOG.md (1 hunks)
- packages/transform-to-vanilla/package.json (1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/moody-otters-shave.md
✅ Files skipped from review due to trivial changes (1)
- packages/transform-to-vanilla/package.json
🔇 Additional comments (1)
packages/css/package.json (1)
5-5
: LGTM: Version update is correct.The version has been correctly updated from 0.0.3 to 0.0.4, which aligns with the PR objectives for a patch release.
/fast-forward |
Triggered from #117 (comment) by @black7375. Trying to fast forward Target branch ( commit 9d5f878754e216b21fa233e215b25523c822a9a7 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Sep 30 19:11:31 2024 +0900
Chore: Versioning for PMC S24 Pull request ( commit 3b26c193de8b4a5e4acd651f4d82cf706e01d35b (pull_request/changeset-release/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Sep 30 19:42:10 2024 +0900
Chore: Version Packages Fast forwarding $ git push origin 3b26c193de8b4a5e4acd651f4d82cf706e01d35b:main
To https://github.com/mincho-js/mincho.git
9d5f878..3b26c19 3b26c193de8b4a5e4acd651f4d82cf706e01d35b -> main |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@mincho-js/css@0.0.4
Patch Changes
#116
9d5f878
Thanks @black7375! - Variant featuresUpdated dependencies [
9d5f878
]:@mincho-js/transform-to-vanilla@0.0.3
Patch Changes
9d5f878
Thanks @black7375! - Variant featuresSummary by CodeRabbit
New Features
@mincho-js/css
and@mincho-js/transform-to-vanilla
packages.Updates
@mincho-js/css
to version 0.0.4, including new functionality and improved package structure.@mincho-js/transform-to-vanilla
to version 0.0.3, reflecting minor changes and dependency updates.