Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #117

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Version Packages #117

merged 1 commit into from
Sep 30, 2024

Conversation

black7375
Copy link
Contributor

@black7375 black7375 commented Sep 30, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@mincho-js/css@0.0.4

Patch Changes

@mincho-js/transform-to-vanilla@0.0.3

Patch Changes

Summary by CodeRabbit

  • New Features

    • Introduced variant features in the @mincho-js/css and @mincho-js/transform-to-vanilla packages.
  • Updates

    • Updated @mincho-js/css to version 0.0.4, including new functionality and improved package structure.
    • Updated @mincho-js/transform-to-vanilla to version 0.0.3, reflecting minor changes and dependency updates.

Copy link

coderabbitai bot commented Sep 30, 2024

Walkthrough

The pull request involves the removal of a file containing patch declarations for the @mincho-js/transform-to-vanilla and @mincho-js/css packages, indicating that associated patches and variant features are no longer part of the codebase. Additionally, both packages have been updated to new versions, introducing variant features and updating dependencies. The package.json files for both packages reflect these changes, including version increments and updates to the exports section.

Changes

File(s) Change Summary
.changeset/moody-otters-shave.md Removed patch declarations for @mincho-js/transform-to-vanilla and @mincho-js/css.
changelog for @mincho-js/css Updated to version 0.0.4; added variant features and updated dependencies.
changelog for @mincho-js/transform-to-vanilla Updated to version 0.0.3; added variant features and updated dependencies.
package.json for @mincho-js/css Updated from version 0.0.3 to 0.0.4; modified exports section for new paths.
package.json for @mincho-js/transform-to-vanilla Updated from version 0.0.2 to 0.0.3; version increment only, no other changes.

Possibly related PRs

  • Implement Variant Reference #50 #57: Implements enhancements to the cssVariants function, introducing new functionality related to variant references, aligning with the focus on variant features.
  • Chore: Versioning for PMC S24 #116: Adds new patch dependencies for @mincho-js/transform-to-vanilla and @mincho-js/css, directly related to the changes in this PR regarding variant features.

🐰 In the code, we hop and play,
With variant features brightening the way.
From patches gone, new paths we chart,
In our packages, we take great heart.
A leap of joy, a code delight,
Together we code, making things right! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Triggered from #117 by @​black7375.

Checking if we can fast forward main (9d5f878) to changeset-release/main (3b26c19).

Target branch (main):

commit 9d5f878754e216b21fa233e215b25523c822a9a7 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Sep 30 19:11:31 2024 +0900

    Chore: Versioning for PMC S24

Pull request (changeset-release/main):

commit 3b26c193de8b4a5e4acd651f4d82cf706e01d35b (pull_request/changeset-release/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Sep 30 19:42:10 2024 +0900

    Chore: Version Packages

It is possible to fast forward main (9d5f878) to changeset-release/main (3b26c19). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to changeset-release/main.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
packages/transform-to-vanilla/CHANGELOG.md (1)

3-7: LGTM! Consider adding more details to the changelog entry.

The new changelog entry for version 0.0.3 is correctly structured and consistent with the PR objectives. It properly references the PR, commit, and contributor.

Consider expanding on "Variant features" to provide more context about what was added or changed. This will help users understand the impact of this update more clearly.

For example:

- - [#116](https://github.com/mincho-js/mincho/pull/116) [`9d5f878`](https://github.com/mincho-js/mincho/commit/9d5f878754e216b21fa233e215b25523c822a9a7) Thanks [@black7375](https://github.com/black7375)! - Variant features
+ - [#116](https://github.com/mincho-js/mincho/pull/116) [`9d5f878`](https://github.com/mincho-js/mincho/commit/9d5f878754e216b21fa233e215b25523c822a9a7) Thanks [@black7375](https://github.com/black7375)! - Added variant features to enhance customization options
packages/css/CHANGELOG.md (1)

3-10: LGTM with a minor suggestion for improvement.

The changelog entry for version 0.0.4 is structurally sound and follows the established format. It correctly references the PR, commit, and updated dependencies. However, the description "Variant features" could be more informative.

Consider expanding on "Variant features" to provide more context about what specific features were added or modified. This will help users understand the impact of the update more clearly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9d5f878 and 3b26c19.

📒 Files selected for processing (5)
  • .changeset/moody-otters-shave.md (0 hunks)
  • packages/css/CHANGELOG.md (1 hunks)
  • packages/css/package.json (1 hunks)
  • packages/transform-to-vanilla/CHANGELOG.md (1 hunks)
  • packages/transform-to-vanilla/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/moody-otters-shave.md
✅ Files skipped from review due to trivial changes (1)
  • packages/transform-to-vanilla/package.json
🔇 Additional comments (1)
packages/css/package.json (1)

5-5: LGTM: Version update is correct.

The version has been correctly updated from 0.0.3 to 0.0.4, which aligns with the PR objectives for a patch release.

packages/transform-to-vanilla/CHANGELOG.md Show resolved Hide resolved
@black7375
Copy link
Contributor Author

/fast-forward

Copy link
Contributor

Triggered from #117 (comment) by @​black7375.

Trying to fast forward main (9d5f878) to changeset-release/main (3b26c19).

Target branch (main):

commit 9d5f878754e216b21fa233e215b25523c822a9a7 (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Sep 30 19:11:31 2024 +0900

    Chore: Versioning for PMC S24

Pull request (changeset-release/main):

commit 3b26c193de8b4a5e4acd651f4d82cf706e01d35b (pull_request/changeset-release/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Sep 30 19:42:10 2024 +0900

    Chore: Version Packages

Fast forwarding main (9d5f878) to changeset-release/main (3b26c19).

$ git push origin 3b26c193de8b4a5e4acd651f4d82cf706e01d35b:main
To https://github.com/mincho-js/mincho.git
   9d5f878..3b26c19  3b26c193de8b4a5e4acd651f4d82cf706e01d35b -> main

@github-actions github-actions bot merged commit 3b26c19 into main Sep 30, 2024
7 checks passed
@github-actions github-actions bot deleted the changeset-release/main branch September 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant