Merge pull request #12 from mineiros-io/align-with-sc2155

align with SC2155 and declare local variables first before setting va…
mineiros-io · May 27, 2020 · ce4373c · ce4373c
2 parents 5103816 + 43c3325
commit ce4373c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pre_commit_hooks/make/phony-targets.sh b/pre_commit_hooks/make/phony-targets.sh
@@ -6,8 +6,11 @@ EXITCODE=0
 
 validate_phony_targets() {
     local file=$1
-    local source=$(make -npq -f "${file}" | grep -E '^.PHONY:')
-    local targets=$(sed -n 's#^.PHONY:\(.*\)#\1#p' <<< "${source}")
+    local source
+    local targets
+
+    source=$(make -npq -f "${file}" | grep -E '^.PHONY:')
+    targets=$(sed -n 's#^.PHONY:\(.*\)#\1#p' <<<"${source}")
 
     for target in $targets; do
         # The q command for setting exit codes if a pattern doesn't match,