Add support for allow_update_branch and update provider min version

[soerenmartius]

• BREAKING CHANGE: Add support for allow_update_branch. Bump minimum supported version of the GitHub provider to v5.16
  as it contains a critical fix for branch protections.

[0x46616c6b]

Is there a planned timeline to merge this and also have the branch protection updated to fix the deprecation? Would like to have both in the module to provide this features to my colleagues. Thanks a lot!

[switchdk]

Hi @soerenmartius I don't know the module particularly well but thought I would try to provide some feedback. Thanks for updating.

In general, I noticed that branch_protection is referred to as branch_protection_v4. It should probably be updated to reflect the minimum required version is 5.16.

[switchdk]

My understanding is that this uses branch_protection and not branch_protection_v3 so therefore contexts is still the correct term at least that is how I understand the documentation.

[switchdk]

I am not able to find a variable known as branch_protections_v5 in the code. I can find branch_protections_v4 and was wondering if this line is supposed to reference that variable instead? If so, I think we should rename all references to either branch_protections_v5 or just branch_protections.

[tobiasehlert]

@soerenmartius, want to look into updating the PR with the comments made from @switchdk?
I really want to have allow_update_branch 😎

[shinenelson]

Since this is going to be a breaking change, can we also please obsolete the defaults variable and clean the code up?

I could create a pull request for it targeting this branch if that is okay with the maintainers.

[soerenmartius]

branch_protections_v5

yeah that's a fair point - I wanted to do this since ages but as we're currently focussing on https://github.com/mineiros-io/terramate I really didn't find the time yet

[soerenmartius]

Since this is going to be a breaking change, can we also please obsolete the defaults variable and clean the code up?

I could create a pull request for it targeting this branch if that is okay with the maintainers.

Let me discuss with the team if we can invest some time in a major refactoring

[pesarkhobeee]

Hello dear @soerenmartius , any possible date to fix this issue?

[thrix]

@soerenmartius hi, is the required refactoring something that could be written down, then maybe somebody could contribute it :)