-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow clicking on widgets behind the barrier #101
Conversation
WalkthroughThe pull request introduces modifications to the project's configuration and popover functionality. Changes include updating the Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Overall lgtm, I left a few minor comments.
Please also add a test case for bool allowClicksOnBackground.
and fix CI.
lib/src/popover_route.dart
: Added a newPopoverRoute
class that extendsRawDialogRoute
and includes theallowClicksOnBackground
property to control whether widgets behind the barrier can receive pointer events.lib/src/popover.dart
: Updated theshowPopover
function to usePopoverRoute
instead ofRawDialogRoute
and added theallowClicksOnBackground
parameter to customize the behavior.Closes #96
Solves #27
Pre-launch Checklist
///
).Summary by CodeRabbit
New Features
Chores
.gitignore
to improve version management and IDE settings tracking.Documentation
Tests