Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐋 Add Dockerfile #21

Merged
merged 19 commits into from
Nov 29, 2023
Merged

🐋 Add Dockerfile #21

merged 19 commits into from
Nov 29, 2023

Conversation

jacobwoffenden
Copy link
Member

TBC

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Jacob Woffenden added 2 commits November 21, 2023 14:50
Add Dockerfile
31ee665 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Pin sass
b2290cf 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Nov 21, 2023
michaeljcollinsuk and others added 5 commits November 21, 2023 15:04
@michaeljcollinsuk
Copy js and other static assets
ca768ba
Add entrypoint
a8d4f1c 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@michaeljcollinsuk
Copy project source code, and update dependencies
7a92767
Add run.md
a296c64 
Update entrypoint.sh

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@michaeljcollinsuk
Add collectstatic to Dockerfile
4f72aa4
@michaeljcollinsuk michaeljcollinsuk linked an issue Nov 23, 2023 that may be closed by this pull request
🐳 Create Dockerfile for Data Platform Control Panel ministryofjustice/analytical-platform#2478
Closed
3 tasks
@michaeljcollinsuk michaeljcollinsuk marked this pull request as ready for review November 29, 2023 13:17
@michaeljcollinsuk michaeljcollinsuk requested a review from a team November 29, 2023 13:17
ymao2
ymao2 previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ymao2 ymao2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)!

Gary-H9
Gary-H9 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julialawrence
julialawrence approved these changes Nov 29, 2023
View reviewed changes
Copy link

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gary-H9 Gary-H9 merged commit 9891ce0 into main Nov 29, 2023
5 checks passed
@Gary-H9 Gary-H9 deleted the feature/container-build branch November 29, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialawrence julialawrence julialawrence approved these changes

@Gary-H9 Gary-H9 Gary-H9 approved these changes

@ymao2 ymao2 ymao2 left review comments

Assignees

@jacobwoffenden jacobwoffenden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐳 Create Dockerfile for Data Platform Control Panel
5 participants
@jacobwoffenden @ymao2 @Gary-H9 @julialawrence @michaeljcollinsuk