Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPAT-2026 Establish project structure #3

Merged
merged 29 commits into from
Nov 8, 2023

Conversation

ymao2
Copy link
Contributor

@ymao2 ymao2 commented Nov 7, 2023

  • Add initial project structure
  • Update python dependencies
  • Add pre-commit config to run linting tools
  • Update dev container to install and run postgres, install dependencies and initialise pre-commit

@ymao2 ymao2 requested a review from a team November 7, 2023 09:53
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

ymao2 and others added 6 commits November 7, 2023 10:21
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@Gary-H9
Copy link
Contributor

Gary-H9 commented Nov 7, 2023

Updated devcontainer to include a postgresql , the configuration is in here. Username and password are configured in there and can be changed if desired. Additionally a feature was added to the devcontainer which runs Docker in Docker. From a users perspective this means that postgresql is run in a container inside the devcontainer, and you can see the container running on the standard port 5432. You can connect to the container using the command:

psql -h localhost -U controlpanel

@ymao2 ymao2 changed the title DPAT-2026 Establish project structure and basic tech DPAT-2026 Establish project structure Nov 7, 2023
@michaeljcollinsuk
Copy link
Contributor

Good starting point 👷‍♀️

README.md Show resolved Hide resolved
Jacob Woffenden added 7 commits November 8, 2023 12:09
in post-create.sh

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Jacob Woffenden added 2 commits November 8, 2023 12:58
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
michaeljcollinsuk and others added 3 commits November 8, 2023 15:31
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
…ce/data-platform-control-panel into dpat-2062-tech-structure
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jhpyke jhpyke dismissed jacobwoffenden’s stale review November 8, 2023 15:51

Because it's been done

@jacobwoffenden jacobwoffenden merged commit e509968 into main Nov 8, 2023
5 checks passed
@jacobwoffenden jacobwoffenden deleted the dpat-2062-tech-structure branch November 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants