Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DataHub Catalogue client for dp-catalogue library #2902

Merged
merged 43 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
3b7a36d
Convert CatalogueClient class into ABC base, so OMD and DataHub clien…
tom-webber Jan 12, 2024
6c034b3
- remove unused `get_client_by_name` method for fetching client based…
tom-webber Jan 12, 2024
01c0e66
remove test file
tom-webber Jan 12, 2024
2ad5469
fix test integration
tom-webber Jan 12, 2024
59a15a5
fix linting
tom-webber Jan 12, 2024
b20ad43
mypy lint fix
tom-webber Jan 12, 2024
880a67f
mypy linting
tom-webber Jan 12, 2024
6e4000f
as above
tom-webber Jan 12, 2024
a33db9e
more mypy ignore comments
tom-webber Jan 12, 2024
861efc6
update DataHubCatalogueClient documentation
tom-webber Jan 15, 2024
4459a19
lint
tom-webber Jan 15, 2024
ee96de3
Merge branch 'main' into add-datahub-client-to-dp-catalogue-pkg
tom-webber Jan 15, 2024
d958955
linting?
tom-webber Jan 15, 2024
48962a8
mypy linter driving me nuts
tom-webber Jan 15, 2024
0adf897
test mypy definition line
tom-webber Jan 15, 2024
acaaa59
- add `create_domain` and `create_or_update_data_product` methods to …
tom-webber Jan 15, 2024
fa605e5
rename all `create_or_update_x` methods to `upsert_x`
tom-webber Jan 15, 2024
0b8dc47
fix rename in tests
tom-webber Jan 16, 2024
afa8771
putting in pre-requisites for using MockDataHubGraph as per https://g…
tom-webber Jan 16, 2024
e4d348f
Add missing dependency for datahub testing code
MatMoore Jan 17, 2024
2bdbe91
Add missing code for golden file testing
MatMoore Jan 17, 2024
96d3f80
Add starting point for golden file testing
MatMoore Jan 17, 2024
90d9e0c
Ensure table name is consistent
MatMoore Jan 17, 2024
e231e40
Delint
MatMoore Jan 17, 2024
e45f83e
More linting
MatMoore Jan 17, 2024
f36c6fa
Remove unused testing code
MatMoore Jan 17, 2024
2bf449e
Change the datahub create table test to a snapshot test
MatMoore Jan 17, 2024
7aaafd8
Lint
MatMoore Jan 17, 2024
f7c5dbb
Ignore lint in generated files
MatMoore Jan 17, 2024
53befcb
Don't complain about line endings on snapshot files
MatMoore Jan 17, 2024
6a43861
Test cases where we create data product, domain, table at the same time
MatMoore Jan 17, 2024
4275112
Remove tests of underlying library functionality
MatMoore Jan 17, 2024
4c64468
Split tests into two modules
MatMoore Jan 17, 2024
3e46cbb
Refactor test
MatMoore Jan 17, 2024
a5d59bd
Split client module into smaller files
MatMoore Jan 17, 2024
8a3e10a
Remove unused enum
MatMoore Jan 17, 2024
85fec39
Add DatasetProperties aspect
MatMoore Jan 17, 2024
903b48c
De-linting continues
MatMoore Jan 17, 2024
bfcd822
lint
MatMoore Jan 18, 2024
446d476
Ensure subtypes conform to base type
MatMoore Jan 18, 2024
ec62b5a
lint
MatMoore Jan 18, 2024
0a82461
lint
MatMoore Jan 18, 2024
37130d2
Tweak datahub output
MatMoore Jan 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
from .client import CatalogueClient # noqa: F401
from .client import CatalogueError, ReferencedEntityMissing # noqa: F401
from .entities import CatalogueMetadata # noqa: F401
from .entities import DataProductMetadata # noqa: F401
from .entities import TableMetadata # noqa: F401
from .client import ( # noqa: F401
CatalogueError,
DataHubCatalogueClient,
OpenMetadataCatalogueClient,
ReferencedEntityMissing,
)
from .entities import ( # noqa: F401
CatalogueMetadata,
DataProductMetadata,
TableMetadata,
)
Loading