Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add policy for kms #3143

Merged
merged 20 commits into from
Feb 2, 2024
Merged

add policy for kms #3143

merged 20 commits into from
Feb 2, 2024

Conversation

Emterry
Copy link
Contributor

@Emterry Emterry commented Jan 31, 2024

this pr is adding a kms policy as a potential fix for the kms key merge failure in #3140

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-engineering-production-10ds

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-engineering-production/10ds, Workflow: Terraform, Marker: aws-analytical-platform-data-engineering-production-10ds_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-engineering-production-10ds

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-engineering-production/10ds, Workflow: Terraform, Marker: aws-analytical-platform-data-engineering-production-10ds_plan

@Emterry Emterry marked this pull request as ready for review January 31, 2024 11:54
@Emterry Emterry requested a review from a team January 31, 2024 11:54
julialawrence

This comment was marked as outdated.

Sign in to view

@julialawrence julialawrence self-requested a review January 31, 2024 17:55
@Emterry Emterry marked this pull request as draft February 1, 2024 09:32
@Emterry Emterry marked this pull request as ready for review February 1, 2024 12:44
julialawrence
julialawrence requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have explained better.

terraform/aws/analytical-platform-data-engineering-production/10ds/data.tf Show resolved Hide resolved
terraform/aws/analytical-platform-data-engineering-production/10ds/vpc.tf Outdated Show resolved Hide resolved
julialawrence
julialawrence approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@Emterry Emterry merged commit f48e3b0 into main Feb 2, 2024
14 checks passed
@Emterry Emterry deleted the hotfix-for-kms-2 branch February 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialawrence julialawrence julialawrence approved these changes

Assignees

@Emterry Emterry

Labels
override-static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emterry @julialawrence