Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DP-886/control panel message broker #3146

Merged
merged 1 commit into from
Jan 31, 2024
Merged

DP-886/control panel message broker #3146

merged 1 commit into from
Jan 31, 2024

Conversation

AntFMoJ
Copy link
Contributor

@AntFMoJ AntFMoJ commented Jan 31, 2024

revert changes to data.tf and iam_policies.tf

@AntFMoJ AntFMoJ requested a review from a team January 31, 2024 15:56
@github-actions GitHub Actions
Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-development-control-panel-message-broker

Checkov 🛂: failure

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/control-panel-message-broker, Workflow: Terraform, Marker: aws-analytical-platform-development-control-panel-message-broker_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-development-control-panel-message-broker

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/control-panel-message-broker, Workflow: Terraform, Marker: aws-analytical-platform-development-control-panel-message-broker_plan

michaeljcollinsuk
michaeljcollinsuk approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntFMoJ AntFMoJ merged commit 5b45cdf into main Jan 31, 2024
15 of 16 checks passed
@AntFMoJ AntFMoJ deleted the DP-886/static_analysis_cpmb_3 branch January 31, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees

@AntFMoJ AntFMoJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntFMoJ @michaeljcollinsuk