Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nvidia-device-plugin-ds from prod cluster #4435

Merged
merged 1 commit into from
May 31, 2024
Merged

Remove nvidia-device-plugin-ds from prod cluster #4435

merged 1 commit into from
May 31, 2024

Conversation

AntFMoJ
Copy link
Contributor

@AntFMoJ AntFMoJ commented May 31, 2024 •
edited
Loading

Pull Request Objective

This piece of work is being tracked in this GitHub Issue.

PR to remove nvidia-device-plugin-ds from production cluster. This is to fix the tf state and will be added back in a follow up PR.

@github-actions GitHub Actions
Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-production-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_static_analysis

@AntFMoJ AntFMoJ marked this pull request as ready for review May 31, 2024 15:44
@AntFMoJ AntFMoJ requested a review from a team as a code owner May 31, 2024 15:44
@github-actions GitHub Actions
Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-production-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_plan

@AntFMoJ AntFMoJ changed the title Remove nvidia-device-plugin-ds from prod Remove nvidia-device-plugin-ds from prod cluster May 31, 2024
julialawrence
julialawrence approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tick

@AntFMoJ AntFMoJ merged commit 8766ed8 into main May 31, 2024
18 checks passed
@AntFMoJ AntFMoJ deleted the fix-state-prod branch May 31, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialawrence julialawrence julialawrence approved these changes

Assignees

@AntFMoJ AntFMoJ

Labels
override-static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntFMoJ @julialawrence