Add policy to allow quicksight author access #4437

michaeljcollinsuk · 2024-06-03T08:58:23Z

Policy does not exist in analytical-platform-development account so this PR should create the policy
The policy already existed in data-production account, but was managed in code. Therefore I have imported the state and added the code.

Pull Request Objective

This piece of work is being tracked in this GitHub Issue.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

I have reviewed the style guide and ensured that my code complies with it
All checks have passed (or override label applied, if I've used the override-static-analysis label, I've explained why)
I have self-reviewed my code
I have reviewed the checks and can attest they're as expected

Additional Comments

- Policy does not exist in analytical-platform-development account so this PR should create the policy - The policy already existed in data-production account, but was managed in code. Therefore I have imported the state and added the code.

github-actions · 2024-06-03T08:59:18Z

Terraform Component 🧱: `aws-analytical-platform-data-production-tooling-iam`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/tooling-iam, Workflow: Terraform, Marker: aws-analytical-platform-data-production-tooling-iam_plan

github-actions · 2024-06-03T08:59:24Z

Terraform Component 🧱: `aws-analytical-platform-data-production-tooling-iam`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `true`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/tooling-iam, Workflow: Terraform, Marker: aws-analytical-platform-data-production-tooling-iam_static_analysis

github-actions · 2024-06-03T08:59:41Z

Terraform Component 🧱: `aws-analytical-platform-development-cluster`

Checkov 🛂: `failure`

Trivy 🛂: `failure`

Static Analysis Override Label 🏷️: `true`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

github-actions · 2024-06-03T08:59:47Z

Terraform Component 🧱: `aws-analytical-platform-development-cluster`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

github-actions · 2024-06-03T11:30:47Z

Terraform Component 🧱: `aws-analytical-platform-development-tooling-iam`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `true`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/tooling-iam, Workflow: Terraform, Marker: aws-analytical-platform-development-tooling-iam_static_analysis

github-actions · 2024-06-03T11:31:03Z

Terraform Component 🧱: `auth0-dev-analytics-moj`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `false`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/auth0/dev-analytics-moj, Workflow: Terraform, Marker: auth0-dev-analytics-moj_static_analysis

github-actions · 2024-06-03T11:31:08Z

Terraform Component 🧱: `auth0-alpha-analytics-moj`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `false`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/auth0/alpha-analytics-moj, Workflow: Terraform, Marker: auth0-alpha-analytics-moj_static_analysis

github-actions · 2024-06-03T11:31:14Z

Terraform Component 🧱: `auth0-alpha-analytics-moj`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/auth0/alpha-analytics-moj, Workflow: Terraform, Marker: auth0-alpha-analytics-moj_plan

github-actions · 2024-06-03T11:31:15Z

Terraform Component 🧱: `auth0-dev-analytics-moj`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/auth0/dev-analytics-moj, Workflow: Terraform, Marker: auth0-dev-analytics-moj_plan

github-actions · 2024-06-03T11:32:25Z

Terraform Component 🧱: `aws-analytical-platform-development-tooling-iam`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/tooling-iam, Workflow: Terraform, Marker: aws-analytical-platform-development-tooling-iam_plan

jacobwoffenden

LGTM

The merge-base changed after approval.

jacobwoffenden

LGMT (again)

The merge-base changed after approval.

Add policy to allow quicksight author access

9b12a7b

- Policy does not exist in analytical-platform-development account so this PR should create the policy - The policy already existed in data-production account, but was managed in code. Therefore I have imported the state and added the code.

michaeljcollinsuk requested a review from a team as a code owner June 3, 2024 08:58

github-actions bot assigned michaeljcollinsuk Jun 3, 2024

michaeljcollinsuk and others added 6 commits June 3, 2024 09:42

Lint fixes

225fe1b

More linting

2cd11b7

Attempt to supress checkov warnings

bc0be2e

Create component for quicksight policy in development

aac7859

Merge aac7859 into 824f929

f6a16f4

🤖 Update .github/dependabot.yml

686181f

Fix static analysis warning

68e88c6

michaeljcollinsuk added the override-static-analysis label Jun 3, 2024

jacobwoffenden previously approved these changes Jun 3, 2024

View reviewed changes

moj-data-platform-robot previously approved these changes Jun 3, 2024

View reviewed changes

michaeljcollinsuk closed this Jun 3, 2024

michaeljcollinsuk reopened this Jun 3, 2024

jacobwoffenden approved these changes Jun 3, 2024

View reviewed changes

michaeljcollinsuk merged commit 9dbdfc4 into main Jun 3, 2024
40 checks passed

michaeljcollinsuk deleted the add-quicksight-author-policy branch June 3, 2024 11:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add policy to allow quicksight author access #4437

Add policy to allow quicksight author access #4437

michaeljcollinsuk commented Jun 3, 2024

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

github-actions bot commented Jun 3, 2024 •

edited

Loading

jacobwoffenden left a comment

jacobwoffenden left a comment

Add policy to allow quicksight author access #4437

Add policy to allow quicksight author access #4437

Conversation

michaeljcollinsuk commented Jun 3, 2024

Pull Request Objective

Checklist

Additional Comments

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: aws-analytical-platform-data-production-tooling-iam

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: aws-analytical-platform-data-production-tooling-iam

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: true

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: aws-analytical-platform-development-tooling-iam

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: true

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: auth0-dev-analytics-moj

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: auth0-alpha-analytics-moj

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: auth0-alpha-analytics-moj

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: auth0-dev-analytics-moj

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

github-actions bot commented Jun 3, 2024 • edited Loading

Terraform Component 🧱: aws-analytical-platform-development-tooling-iam

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

jacobwoffenden left a comment

Choose a reason for hiding this comment

jacobwoffenden left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-data-production-tooling-iam`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-data-production-tooling-iam`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `true`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-development-cluster`

Checkov 🛂: `failure`

Trivy 🛂: `failure`

Static Analysis Override Label 🏷️: `true`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-development-cluster`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-development-tooling-iam`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `true`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `auth0-dev-analytics-moj`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `false`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `auth0-alpha-analytics-moj`

Checkov 🛂: `success`

Trivy 🛂: `success`

Static Analysis Override Label 🏷️: `false`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `auth0-alpha-analytics-moj`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `auth0-dev-analytics-moj`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`

github-actions bot commented Jun 3, 2024 •

edited

Loading

Terraform Component 🧱: `aws-analytical-platform-development-tooling-iam`

Terraform Initialization ⚙️: `success`

Terraform Validation 🤖: `success`

Terraform Plan 🛠️: `success`