Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant Control Panel role read policy permissions #4447

Merged

Conversation

michaeljcollinsuk
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk commented Jun 3, 2024

Pull Request Objective

This piece of work is being tracked in this GitHub Issue.

Additional permissions are required by the Control Panel role to check a users IAM policies, to check if they have Quicksight enabled or not

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Terraform Component 🧱: aws-analytical-platform-production-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_plan

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Terraform Component 🧱: aws-analytical-platform-production-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @michaeljcollinsuk, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_static_analysis

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk merged commit 0ec7eec into main Jun 3, 2024
24 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the grant-controlpanel-role-read-policy-permissions branch June 3, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants