Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactor Airflow MNG and LT names #4460

Merged
merged 2 commits into from
Jun 4, 2024
Merged

♻️ Refactor Airflow MNG and LT names #4460

merged 2 commits into from
Jun 4, 2024

Conversation

jacobwoffenden
Copy link
Member

This pull request:

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Refactor MNG and LT
2a56340 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Jun 4, 2024
@jacobwoffenden jacobwoffenden requested a review from a team as a code owner June 4, 2024 16:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-production-airflow

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/airflow, Workflow: Terraform, Marker: aws-analytical-platform-data-production-airflow_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-production-airflow

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/airflow, Workflow: Terraform, Marker: aws-analytical-platform-data-production-airflow_plan

Fix docs
ef5c038 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Gary-H9
Gary-H9 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit 62f79dd into main Jun 4, 2024
14 checks passed
@jacobwoffenden jacobwoffenden deleted the chore/refactor-mng-identifiers branch June 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
override-static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ Refactor new_ code in Airflow Terraform
2 participants
@jacobwoffenden @Gary-H9