Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Add our services and remove catalogue ADRs #4475

Merged
merged 11 commits into from
Jun 7, 2024
Merged

📦 Add our services and remove catalogue ADRs #4475

merged 11 commits into from
Jun 7, 2024

Conversation

bagg3rs
Copy link
Contributor

@bagg3rs bagg3rs commented Jun 5, 2024

Pull Request Objective

#4474

bagg3rs added 3 commits June 4, 2024 22:56
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
…d and renumber

Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
@bagg3rs bagg3rs requested a review from a team as a code owner June 5, 2024 14:47
@bagg3rs bagg3rs marked this pull request as draft June 5, 2024 14:48
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
@jemnery
Copy link
Contributor

jemnery commented Jun 6, 2024

@bagg3rs just confirming you're fine to remove those old catalogue ADRs (004 and 012) 👍

@bagg3rs
Copy link
Contributor Author

bagg3rs commented Jun 6, 2024

@jemnery thanks was meant to say I was just going to do it

bagg3rs added 5 commits June 6, 2024 12:11
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
@bagg3rs bagg3rs marked this pull request as ready for review June 7, 2024 15:05
bagg3rs added 2 commits June 7, 2024 16:06
Signed-off-by: Richard Baguley <20583399+bagg3rs@users.noreply.github.com>
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impeccable use of emojis. Please tell me, did it take a long time to arrive at the decision which one to use?

@bagg3rs bagg3rs merged commit 0afb456 into main Jun 7, 2024
10 checks passed
@bagg3rs bagg3rs deleted the add-services branch June 7, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants