Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed version of em perms commit #4521

Merged
merged 2 commits into from
Jun 11, 2024
Merged

signed version of em perms commit #4521

merged 2 commits into from
Jun 11, 2024

Conversation

matt-heery
Copy link
Contributor

Pull Request Objective

This piece of work is being tracked in
this
GitHub Issue.

Adding access to the 4 buckets listed above for the EM data AWS accounts two for dev and two for prod.

Checklist

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

@matt-heery matt-heery requested a review from a team as a code owner June 11, 2024 14:01
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: false

Pusher: @matt-heery, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_static_analysis

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @matt-heery, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_plan

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question about the comma

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unremove the comma? :octocat:

@matt-heery matt-heery merged commit 6941235 into main Jun 11, 2024
13 of 14 checks passed
@matt-heery matt-heery deleted the em-perms-signed branch June 11, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants