Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mojap-metadata-dev action and adding List Bucket policies #4522

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

matt-heery
Copy link
Contributor

@matt-heery matt-heery commented Jun 11, 2024

Pull Request Objective

This piece of work is being tracked in this GitHub Issue.

Checklist

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

The terraform apply was failing due to a legacy principal, here been replaced by the actual arn (see changes to refer to the original delius iam role), the old role must have been deleted and rewritten or similar. I have checked with @davidbridgwood and he was happy with the changes.

I also added list bucket permissions for the original issue

@matt-heery matt-heery requested a review from a team as a code owner June 11, 2024 16:21
@matt-heery matt-heery changed the title Em/policy update Fixing mojap-metadata-dev action and adding List Bucket policies Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @matt-heery, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_static_analysis

Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @matt-heery, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_plan

@julialawrence julialawrence merged commit 419039f into main Jun 12, 2024
19 checks passed
@julialawrence julialawrence deleted the em/policy-update branch June 12, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants