APS-1815: Throw if page already visited #2297
Open
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froddd
changed the title
froddd
force-pushed
the
bugfix/APS-1815-prevent-task-list-infinite-loop
branch
from
854f090 to
8234977
Compare
froddd
changed the title
When building the main task list or fetching statuses for building un-submitted application summaries, some answer combinations may unintentionally produce an infinite loop due to how the next page to check is determined. To prevent this, a simple trail of pages that have already been visited is built whenever such a loop is running. If a page has already been visited, an error is now thrown: this prevents the current process running infinitely, and will alert us of the trail of pages that caused the infinite loop, so the issue can be remedied.
If a page has no data, the next page defined in the task is selected to continue building the task list. This removes pages from the list of pages to check as the task list is being built, to ensure pages are not checked twice through this.
froddd
force-pushed
the
bugfix/APS-1815-prevent-task-list-infinite-loop
branch
from
8234977 to
e05d04e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the main task list or fetching statuses for building un-submitted application summaries, some answer combinations may unintentionally produce an infinite loop due to how the next page to check is determined.
To prevent this, a simple trail of pages that have already been visited is built whenever such a loop is running. If a page has already been visited, an error is now thrown: this prevents the current process running indefinitely, and will alert us of the trail of pages that caused the infinite loop, so the issue can be remedied.
In addition, when no data has been saved against a given page, the loop attempts to check the next page as defined in the Task. Due to certain logic combinations, this page may already have been checked, which may also produce an infinite loop (or, thanks to the fix above, an error!). To prevent this, pages are removed from the pool as they are checked.
Context
https://dsdmoj.atlassian.net/browse/APS-1815