Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚓ Add CaDeT Actions Runner Helm release #6341

Merged
merged 1 commit into from
May 30, 2024
Merged

⚓ Add CaDeT Actions Runner Helm release #6341

merged 1 commit into from
May 30, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented May 30, 2024 •
edited
Loading

This pull request:

Is part of ministryofjustice/analytical-platform#4422

  • Adds CaDeT's Actions Runner Helm release to production
  • Renames the secret module

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Add CaDeT Helm chart
e949371 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this May 30, 2024
@jacobwoffenden jacobwoffenden requested review from a team as code owners May 30, 2024 16:20
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label May 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table

Running Trivy in terraform/environments/analytical-platform-compute
2024-05-30T16:22:08Z INFO Need to update DB
2024-05-30T16:22:08Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-30T16:22:09Z INFO Vulnerability scanning is enabled
2024-05-30T16:22:09Z INFO Misconfiguration scanning is enabled
2024-05-30T16:22:09Z INFO Need to update the built-in policies
2024-05-30T16:22:09Z INFO Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-30T16:22:10Z INFO Secret scanning is enabled
2024-05-30T16:22:10Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-30T16:22:10Z INFO Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-30T16:22:20Z INFO Number of language-specific files num=0
2024-05-30T16:22:20Z INFO Detected config files num=15

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=59024ebd0aeacad2c1a47d7c8dad123042814dec/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)

Tests: 22 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 22)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=25322b6b6be69db6cca7f167d7b0e5327156a595/vpc-flow-logs.tf (terraform)

Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam-policies.tf (terraform)

Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

Running Trivy in terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table
2024-05-30T16:22:21Z INFO Vulnerability scanning is enabled
2024-05-30T16:22:21Z INFO Misconfiguration scanning is enabled
2024-05-30T16:22:21Z INFO Secret scanning is enabled
2024-05-30T16:22:21Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-30T16:22:21Z INFO Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-30T16:22:21Z INFO Number of language-specific files num=0
2024-05-30T16:22:21Z INFO Detected config files num=0
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-05-30 16:22:23,467 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,467 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,468 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,468 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,468 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,468 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,468 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,468 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.12.0 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,469 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.0.0 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,469 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:2.11.1 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,469 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-05-30 16:22:23,469 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.2.1 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 40, Failed checks: 0, Skipped checks: 52


checkov_exitcode=0

*****************************

Running Checkov in terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39

checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

*****************************

Running tflint in terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-05-30T16:22:08Z	INFO	Need to update DB
2024-05-30T16:22:08Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-05-30T16:22:09Z	INFO	Vulnerability scanning is enabled
2024-05-30T16:22:09Z	INFO	Misconfiguration scanning is enabled
2024-05-30T16:22:09Z	INFO	Need to update the built-in policies
2024-05-30T16:22:09Z	INFO	Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-05-30T16:22:10Z	INFO	Secret scanning is enabled
2024-05-30T16:22:10Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-30T16:22:10Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-30T16:22:20Z	INFO	Number of language-specific files	num=0
2024-05-30T16:22:20Z	INFO	Detected config files	num=15

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=59024ebd0aeacad2c1a47d7c8dad123042814dec/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)
=============================================================================================================================================================================
Tests: 22 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 22)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=25322b6b6be69db6cca7f167d7b0e5327156a595/vpc-flow-logs.tf (terraform)
========================================================================================================================================
Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam-policies.tf (terraform)
===========================
Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

*****************************

Running Trivy in terraform/environments/analytical-platform-compute/src/helm/values/actions-runners/create-a-derived-table
2024-05-30T16:22:21Z	INFO	Vulnerability scanning is enabled
2024-05-30T16:22:21Z	INFO	Misconfiguration scanning is enabled
2024-05-30T16:22:21Z	INFO	Secret scanning is enabled
2024-05-30T16:22:21Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-05-30T16:22:21Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.51/docs/scanner/secret/#recommendation for faster secret detection
2024-05-30T16:22:21Z	INFO	Number of language-specific files	num=0
2024-05-30T16:22:21Z	INFO	Detected config files	num=0
trivy_exitcode=0

Gary-H9
Gary-H9 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit 10cdb76 into main May 30, 2024
14 checks passed
@jacobwoffenden jacobwoffenden deleted the actions-runner-cadet-deploy branch May 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @Gary-H9