Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌊 Add Lake Formation settings in APC #7255

Merged
merged 3 commits into from
Jul 23, 2024
Merged

🌊 Add Lake Formation settings in APC #7255

merged 3 commits into from
Jul 23, 2024

Conversation

jacobwoffenden
Copy link
Member

Add LF settings
d618f0d 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Jul 23, 2024
@jacobwoffenden jacobwoffenden requested review from a team as code owners July 23, 2024 16:06
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

Running Trivy in terraform/environments/analytical-platform-compute
2024-07-23T16:08:26Z INFO Need to update DB
2024-07-23T16:08:26Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-23T16:08:28Z INFO Vulnerability scanning is enabled
2024-07-23T16:08:28Z INFO Misconfiguration scanning is enabled
2024-07-23T16:08:28Z INFO Need to update the built-in policies
2024-07-23T16:08:28Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-23T16:08:28Z INFO Secret scanning is enabled
2024-07-23T16:08:28Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-23T16:08:28Z INFO Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-23T16:08:37Z INFO Number of language-specific files num=0
2024-07-23T16:08:37Z INFO Detected config files num=27

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=705eb80cfacf563f74f760261c2154d2fd9f1d87/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=2e417ad0ce830893127476436179ef483485ae84/vpc-flow-logs.tf (terraform)

Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

terraform-aws-modules/eks/aws/modules/karpenter/main.tf (terraform)

Tests: 4 (SUCCESSES: 2, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-07-23 16:08:39,568 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.20.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,568 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws//modules/karpenter:20.20.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,568 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.3.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,568 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.9.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,569 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:4.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,569 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/rds/aws:6.8.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,569 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.4.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,569 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,569 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,569 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,570 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,570 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-github-oidc-role:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,570 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,570 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,570 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,570 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:08:39,571 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.9.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 87, Failed checks: 0, Skipped checks: 96


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-07-23T16:08:26Z	INFO	Need to update DB
2024-07-23T16:08:26Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-23T16:08:28Z	INFO	Vulnerability scanning is enabled
2024-07-23T16:08:28Z	INFO	Misconfiguration scanning is enabled
2024-07-23T16:08:28Z	INFO	Need to update the built-in policies
2024-07-23T16:08:28Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-23T16:08:28Z	INFO	Secret scanning is enabled
2024-07-23T16:08:28Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-23T16:08:28Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-23T16:08:37Z	INFO	Number of language-specific files	num=0
2024-07-23T16:08:37Z	INFO	Detected config files	num=27

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=705eb80cfacf563f74f760261c2154d2fd9f1d87/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=2e417ad0ce830893127476436179ef483485ae84/vpc-flow-logs.tf (terraform)
========================================================================================================================================
Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


terraform-aws-modules/eks/aws/modules/karpenter/main.tf (terraform)
===================================================================
Tests: 4 (SUCCESSES: 2, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

Add aws_iam_session_context
4537629 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-test July 23, 2024 16:13 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

Running Trivy in terraform/environments/analytical-platform-compute
2024-07-23T16:13:18Z INFO Need to update DB
2024-07-23T16:13:18Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-23T16:13:20Z INFO Vulnerability scanning is enabled
2024-07-23T16:13:20Z INFO Misconfiguration scanning is enabled
2024-07-23T16:13:20Z INFO Need to update the built-in policies
2024-07-23T16:13:20Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-23T16:13:21Z INFO Secret scanning is enabled
2024-07-23T16:13:21Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-23T16:13:21Z INFO Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-23T16:13:34Z INFO Number of language-specific files num=0
2024-07-23T16:13:34Z INFO Detected config files num=27

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=705eb80cfacf563f74f760261c2154d2fd9f1d87/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=2e417ad0ce830893127476436179ef483485ae84/vpc-flow-logs.tf (terraform)

Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

terraform-aws-modules/eks/aws/modules/karpenter/main.tf (terraform)

Tests: 4 (SUCCESSES: 2, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-07-23 16:13:37,066 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.20.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,066 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws//modules/karpenter:20.20.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,066 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.3.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,066 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.9.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,066 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:4.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,066 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/rds/aws:6.8.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,067 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.4.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,067 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,067 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,067 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,067 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,067 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-github-oidc-role:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,068 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,068 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,068 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,068 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:13:37,068 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.9.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 87, Failed checks: 0, Skipped checks: 96


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-07-23T16:13:18Z	INFO	Need to update DB
2024-07-23T16:13:18Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-23T16:13:20Z	INFO	Vulnerability scanning is enabled
2024-07-23T16:13:20Z	INFO	Misconfiguration scanning is enabled
2024-07-23T16:13:20Z	INFO	Need to update the built-in policies
2024-07-23T16:13:20Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-23T16:13:21Z	INFO	Secret scanning is enabled
2024-07-23T16:13:21Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-23T16:13:21Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-23T16:13:34Z	INFO	Number of language-specific files	num=0
2024-07-23T16:13:34Z	INFO	Detected config files	num=27

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=705eb80cfacf563f74f760261c2154d2fd9f1d87/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=2e417ad0ce830893127476436179ef483485ae84/vpc-flow-logs.tf (terraform)
========================================================================================================================================
Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


terraform-aws-modules/eks/aws/modules/karpenter/main.tf (terraform)
===================================================================
Tests: 4 (SUCCESSES: 2, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-development July 23, 2024 16:13 — with GitHub Actions Inactive
michaeljcollinsuk
michaeljcollinsuk previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julialawrence
julialawrence previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💧

Fix data location
ea26f26 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

Running Trivy in terraform/environments/analytical-platform-compute
2024-07-23T16:25:00Z INFO Need to update DB
2024-07-23T16:25:00Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-23T16:25:03Z INFO Vulnerability scanning is enabled
2024-07-23T16:25:03Z INFO Misconfiguration scanning is enabled
2024-07-23T16:25:03Z INFO Need to update the built-in policies
2024-07-23T16:25:03Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-23T16:25:04Z INFO Secret scanning is enabled
2024-07-23T16:25:04Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-23T16:25:04Z INFO Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-23T16:25:14Z INFO Number of language-specific files num=0
2024-07-23T16:25:14Z INFO Detected config files num=27

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=705eb80cfacf563f74f760261c2154d2fd9f1d87/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=2e417ad0ce830893127476436179ef483485ae84/vpc-flow-logs.tf (terraform)

Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

terraform-aws-modules/eks/aws/modules/karpenter/main.tf (terraform)

Tests: 4 (SUCCESSES: 2, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-07-23 16:25:17,085 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.20.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,085 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws//modules/karpenter:20.20.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.3.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.9.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/s3-bucket/aws:4.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/rds/aws:6.8.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.4.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,086 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-github-oidc-role:5.41.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.1.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,087 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-07-23 16:25:17,088 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.9.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 87, Failed checks: 0, Skipped checks: 96


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-07-23T16:25:00Z	INFO	Need to update DB
2024-07-23T16:25:00Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-23T16:25:03Z	INFO	Vulnerability scanning is enabled
2024-07-23T16:25:03Z	INFO	Misconfiguration scanning is enabled
2024-07-23T16:25:03Z	INFO	Need to update the built-in policies
2024-07-23T16:25:03Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-23T16:25:04Z	INFO	Secret scanning is enabled
2024-07-23T16:25:04Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-23T16:25:04Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-23T16:25:14Z	INFO	Number of language-specific files	num=0
2024-07-23T16:25:14Z	INFO	Detected config files	num=27

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=705eb80cfacf563f74f760261c2154d2fd9f1d87/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-vpc?ref=2e417ad0ce830893127476436179ef483485ae84/vpc-flow-logs.tf (terraform)
========================================================================================================================================
Tests: 2 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)


terraform-aws-modules/eks/aws/modules/karpenter/main.tf (terraform)
===================================================================
Tests: 4 (SUCCESSES: 2, FAILURES: 0, EXCEPTIONS: 2)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

michaeljcollinsuk
michaeljcollinsuk approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit c08307f into main Jul 23, 2024
14 checks passed
@jacobwoffenden jacobwoffenden deleted the feat/apc-lf branch July 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

@julialawrence julialawrence julialawrence left review comments

Assignees

@jacobwoffenden jacobwoffenden

Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobwoffenden @michaeljcollinsuk @julialawrence