Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace global package with native #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rtritto
Copy link

@rtritto rtritto commented Jan 7, 2025

Alternative to #183

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for effervescent-moonbeam-e4210e failed.

Name Link
🔨 Latest commit e5cc996
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-moonbeam-e4210e/deploys/677d33e2a11fc10008b04cdd

@mister-ben
Copy link
Owner

A problem with this would be that globalThis is supported from Chrome 71, but Video.js is maintaining compatibility with older versions because of Smart TVs. Although this plugin isn't useful on TVs, if someone has the plugin in use anyway in old Chrome environments this change could cause new errors.

@rtritto
Copy link
Author

rtritto commented Jan 8, 2025

Can we use directly?

window.document  // document
window  // window

Note: I'm using this plugin also with Smart TVs. If needed, I can do some test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants