Remove unused capacity and add NewRef function to queue tutorial #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r for queue tutorial. This will make proofs easier by proving a function that directly returns a pointer which will have a spec and proof that do the work of initializing all of the ghost state. Also the capacity here is unused. It seems like the idea was to make the slice fixed length but in reality the capacity is only used in Go slices to determine when to upsize and in this case since the initial size is queue_size it actually has no effect. This will be followed by updates to goose code and proofs.
lredlin
added a commit
to lredlin/perennial
that referenced
this pull request
Jan 25, 2025
This is the proof and code changes associated with mit-pdos/gokv#9.
lredlin
added a commit
to lredlin/perennial
that referenced
this pull request
Jan 25, 2025
associated change in mit-pdos/gokv#9
lredlin
added a commit
to lredlin/perennial
that referenced
this pull request
Jan 25, 2025
associated change in mit-pdos/gokv#9
|
Thanks! |
zeldovich
pushed a commit
to mit-pdos/perennial
that referenced
this pull request
Jan 26, 2025
associated change in mit-pdos/gokv#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make proofs easier by proving a function that directly returns a pointer which will have a spec and proof that do the work of initializing all of the ghost state. Also the capacity here is unused. It seems like the idea was to make the slice fixed length but in reality the capacity is only used in Go slices to determine when to upsize and in this case since the initial size is queue_size it actually has no effect. This will be followed by updates to goose code and proofs.