add validation to capa problem authoring markdown #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaIbnFarooq
changed the title
ziafazal
reviewed
May 31, 2021
There was a problem hiding this comment.
@HamzaIbnFarooq overall LGTM. few typos needs to be fixed and I have question.
| @@ -402,6 +402,9 @@ | |||
| line = lines[i].trim(); | |||
| if (line.length > 0) { | |||
| textHint = extractHint(line, true); | |||
| if (!textHint.nothint) { | |||
| throw new Error("One of the provided options don't have valid text value") | |||
There was a problem hiding this comment.
replace don't have valid with doesn't have a valid. Are these error messages are marked for internationalization?
There was a problem hiding this comment.
I have fixed the typo and the messages are already internationalized in the showErrorMeassage method but I have added translations to individual strings as well.
HamzaIbnFarooq
force-pushed
the
hamza/add_validation_to_capa_problem_authoring_markdown
branch
from
3dec514 to
88d0d01
Compare
HamzaIbnFarooq
force-pushed
the
hamza/add_validation_to_capa_problem_authoring_markdown
branch
2 times, most recently
from
2975572 to
8621270
Compare
HamzaIbnFarooq
force-pushed
the
hamza/add_validation_to_capa_problem_authoring_markdown
branch
from
745c00d to
9dc9a34
Compare
HamzaIbnFarooq
added
upstream
Waiting on Author
and removed
Needs Review
Waiting on Author
labels
|
@pdpinch I have created an upstream PR related to this feature: https://github.com/edx/edx-platform/pull/27858 |
HamzaIbnFarooq
force-pushed
the
hamza/add_validation_to_capa_problem_authoring_markdown
branch
3 times, most recently
from
389595b to
d85f98a
Compare
Before this commit, if a course author created a capa mcqs or similar problem without providing any answer text for an option the question would be created causing abnormal behavior for learners. This commit will validate answer text of all options and raise an error message to author to fix the issue on the go.
…fix response report generation If an author has created a capa problem like an mcqs or something similar without providing answer text to an option and some learner selected that option then the response report generation will fail due to that missing answer text. The current commit will add default text to be substituted and prevents report generation crash.
HamzaIbnFarooq
force-pushed
the
hamza/add_validation_to_capa_problem_authoring_markdown
branch
from
d85f98a to
9e655a4
Compare
HamzaIbnFarooq
changed the base branch from
hamza/edx_latest_master
to
mitx/lilac
HamzaIbnFarooq
changed the base branch from
mitx/lilac
to
hamza/edx_latest_master
|
The upstream PR https://github.com/edx/edx-platform/pull/27858 has been merged so closing this internal PR as well |
HamzaIbnFarooq
deleted the
hamza/add_validation_to_capa_problem_authoring_markdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#239
#240
What this PR does
It adds validation to CAPA problems and shows a notification to the course author regarding the issue, along with fixing old response report generation issues by providing a default value for the problems having no text values for answer options.
How to test this PR
To understand the purpose of this PR, follow the below steps to reproduce the issue:
Data DownloadunderInstructortabReportssection, select the Problem and pressCreate a report of problem responsesThe error will be generated.
Now use the current PR and go through the same process, and you will see that the editor will not allow saving such content and mentions an error message instead.
Screenshots