Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prolearn ETL code #1966

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove prolearn ETL code #1966

merged 1 commit into from
Jan 21, 2025

Conversation

mbertrand
Copy link
Member

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/6272

Description (What does it do?)

Removes prolearn ETL code and management command. The only reference left should be in the ETLSource enum (because there will still be some old unpublished resources in the database that came from this pipeline).

How can this be tested?

The following should still work fine, as long as MITPE_BASE_URL and SEE_* env settings are the same as on RC:

./manage.py backpopulate_sloan_data
./manage.py backpopulate_mitpe_data

@mbertrand mbertrand force-pushed the mb/rm_prolearn branch 2 times, most recently from f367b7d to 9871f3a Compare January 16, 2025 20:26
@mbertrand mbertrand added the Needs Review An open Pull Request that is ready for review label Jan 16, 2025
@abeglova abeglova self-assigned this Jan 17, 2025
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we keeping the prolearn ETLSource and unpublished resources instead of just deleting them? Other than that this looks good

Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mbertrand mbertrand merged commit 58a19cf into main Jan 21, 2025
11 checks passed
This was referenced Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants