Course About Page: update font and styles #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachellougee
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
The fonts are Inter now. The line-height also matched with design, which 38px, but it doesn't look the same as in the screenshot reported in https://github.com/mitodl/hq/issues/2647. That's design issue or my eyes
Anyway, LGTM to match the design
|
@rachellougee I was also confused about the screenshots in the issue. But those were taken from production old design. And for this fix we are implementing the figma design, which is different. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/2618
Fix https://github.com/mitodl/hq/issues/2647
Description (What does it do?)
Following the designs here https://www.figma.com/file/Gs4zIhOFv5gVvafawwl6PF/MITx-Online?type=design&node-id=0%3A1&mode=dev.
Updated the font family for new-design styles.
Screenshots (if appropriate):
Before:
After:
