Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Django Admin search for Products #2247

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix Django Admin search for Products #2247

merged 1 commit into from
Jun 12, 2024

Conversation

collinpreston
Copy link
Contributor

@collinpreston collinpreston commented Jun 11, 2024 •
edited
Loading

What are the relevant tickets?

#2201
#1895

Description (What does it do?)

Fixes the Django Admin search for Products

How can this be tested?

  1. Have an instance of MITx Online with a Product created.
  2. Visit mitxonline.odl.local:8013/admin/ecommerce/product/
  3. Use the search bar to search for your Product. Verify that your Product is displayed if the search matches.
  4. Use the search bar to search for a non-existing Product (random string that doesn't match any Product string). Verify that your Product is not displayed.

@collinpreston collinpreston linked an issue Jun 11, 2024 that may be closed by this pull request
Impossible to search for product by course run #2201
Closed
@collinpreston collinpreston linked an issue Jun 11, 2024 that may be closed by this pull request
500 error when searching on the admin page for product #1895
Closed
@JenniWhitman JenniWhitman self-assigned this Jun 12, 2024
JenniWhitman
JenniWhitman approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@JenniWhitman JenniWhitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to search and get results as I expected.

@collinpreston collinpreston merged commit 5775ef4 into main Jun 12, 2024
7 checks passed
@collinpreston collinpreston deleted the 2201-impossible-to-search-for-product-by-course-run branch June 12, 2024 15:13
@odlbot odlbot mentioned this pull request Jun 12, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniWhitman JenniWhitman JenniWhitman approved these changes

Assignees

@JenniWhitman JenniWhitman

Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to search for product by course run 500 error when searching on the admin page for product
2 participants
@collinpreston @JenniWhitman