Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites to courses API #2321

Merged
merged 21 commits into from
Aug 5, 2024

Conversation

cp-at-mit
Copy link
Contributor

What are the relevant tickets?

https://github.com/mitodl/hq/issues/4947

Description (What does it do?)

Adds a required_prerequisites field to the courses api

How can this be tested?

Make a GET call to the courses API for a course with nothing defined in the prerequisite field of the course page in the CMS. Verify that the required_prerequisites in the API response is false.

Make a GET call to the courses API for a course with text defined in the prerequisite field of the course page in the CMS. Verify that the required_prerequisites in the API response is true.

@cp-at-mit cp-at-mit marked this pull request as ready for review August 1, 2024 19:21
@annagav annagav self-requested a review August 5, 2024 13:19
@annagav annagav self-assigned this Aug 5, 2024
@annagav
Copy link
Contributor

annagav commented Aug 5, 2024

@cp-at-mit why are we adding this to v1 and not v2?

@cp-at-mit
Copy link
Contributor Author

@cp-at-mit why are we adding this to v1 and not v2?

I can move it to V2 if you think I should

@annagav
Copy link
Contributor

annagav commented Aug 5, 2024

As far as I know mit-open is using v2 of the course api.

Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cp-at-mit cp-at-mit merged commit 4998810 into main Aug 5, 2024
7 checks passed
@cp-at-mit cp-at-mit deleted the add-required-prerequisites-to-courses-api branch August 5, 2024 17:44
@odlbot odlbot mentioned this pull request Aug 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants