-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerequisites to courses API #2321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ithub.com/mitodl/mitxonline into add-required-prerequisites-to-courses-api
for more information, see https://pre-commit.ci
…ithub.com/mitodl/mitxonline into add-required-prerequisites-to-courses-api
for more information, see https://pre-commit.ci
…ithub.com/mitodl/mitxonline into add-required-prerequisites-to-courses-api
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@cp-at-mit why are we adding this to v1 and not v2? |
I can move it to V2 if you think I should |
for more information, see https://pre-commit.ci
As far as I know mit-open is using v2 of the course api. |
annagav
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/4947
Description (What does it do?)
Adds a required_prerequisites field to the courses api
How can this be tested?
Make a GET call to the courses API for a course with nothing defined in the prerequisite field of the course page in the CMS. Verify that the required_prerequisites in the API response is false.
Make a GET call to the courses API for a course with text defined in the prerequisite field of the course page in the CMS. Verify that the required_prerequisites in the API response is true.