Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/password component #562

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

Feature/password component #562

wants to merge 69 commits into from

Conversation

ins0
Copy link
Member

@ins0 ins0 commented Jul 2, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 34.11% 5365 / 15725
🔵 Statements 34.11% 5365 / 15725
🔵 Functions 61.6% 467 / 758
🔵 Branches 78.2% 843 / 1078
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/vite.build.config.base.ts 0% 100% 100% 0% 2-146
packages/components/src/components/Label/Label.tsx 97.14% 33.33% 100% 97.14% 37
packages/components/src/components/PasswordCreationField/PasswordCreationField.tsx 97.83% 89.74% 83.33% 97.83% 210-211, 237-238, 275-276
packages/components/src/components/PasswordCreationField/index.ts 0% 0% 0% 0% 1-6
packages/components/src/components/PasswordCreationField/components/ComplexityIndicator/ComplexityIndicator.tsx 100% 100% 100% 100%
packages/components/src/components/PasswordCreationField/components/FieldLabel/FieldLabel.tsx 100% 100% 100% 100%
packages/components/src/components/PasswordCreationField/components/ValidationResultEntry/ValidationResultEntry.tsx 96.66% 50% 100% 96.66% 23
packages/components/src/components/PasswordCreationField/lib/generateValidationTranslation.ts 90.62% 83.33% 100% 90.62% 14, 24-25
packages/components/src/components/PasswordCreationField/lib/getStatusFromPolicyValidationResult.ts 81.25% 60% 100% 81.25% 15, 17-18
packages/components/src/components/PasswordCreationField/lib/getStatusTextFromPolicyValidationResult.ts 64.28% 80% 100% 64.28% 11-15, 21-25
packages/components/src/components/PasswordCreationField/stories/Default.stories.tsx 0% 100% 100% 0% 2-94
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
packages/components/src/integrations/react-hook-form/components/Field/Field.tsx 95.58% 57.14% 100% 95.58% 43-45
packages/components/src/integrations/react-hook-form/components/Field/stories/Default.stories.tsx 0% 100% 100% 0% 2-205
packages/components/src/lib/componentFactory/flowComponent.tsx 94.28% 88.88% 100% 94.28% 71-72
Generated in workflow #1937 for commit 0333304 by the Vitest Coverage Report Action

@ins0 ins0 temporarily deployed to github-pages-preview July 3, 2024 11:16 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview July 3, 2024 11:24 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview-storybook July 3, 2024 11:24 — with GitHub Actions Inactive
@ins0 ins0 marked this pull request as draft July 3, 2024 13:23
@ins0 ins0 temporarily deployed to github-pages-preview July 29, 2024 09:08 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview-storybook July 29, 2024 09:08 — with GitHub Actions Inactive
ins0 added 2 commits November 25, 2024 15:34
@ins0
Merge branch 'main' into feature/password-component
ec794ee 
# Conflicts:
#	.pnp.cjs
#	.yarn/releases/yarn-4.3.1.cjs
#	.yarnrc.yml
#	packages/components/package.json
#	packages/components/src/integrations/react-hook-form/components/Field/Field.tsx
#	packages/components/src/integrations/react-hook-form/components/Field/stories/Default.stories.tsx
#	packages/components/vite.build.config.ts
#	packages/design-tokens/src/content/label.yml
#	packages/design-tokens/src/status/password-creation-field.yml
#	yarn.lock
@ins0
resolve conflicts
8b96980
@ins0 ins0 temporarily deployed to github-pages-preview-storybook November 25, 2024 15:14 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview November 25, 2024 16:20 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview-storybook November 25, 2024 16:20 — with GitHub Actions Inactive
mfal
mfal reviewed Jan 7, 2025
View reviewed changes
...mponents/src/components/PasswordCreationField/components/ComplexityIndicator/complexity.scss Show resolved Hide resolved
packages/components/src/components/PasswordCreationField/components/FieldLabel/FieldLabel.tsx Outdated Show resolved Hide resolved
packages/components/src/components/PasswordCreationField/components/FieldLabel/FieldLabel.tsx Outdated Show resolved Hide resolved
packages/components/src/components/PasswordCreationField/components/FieldLabel/FieldLabel.tsx Outdated Show resolved Hide resolved
packages/components/src/components/PasswordCreationField/lib/generateValidationTranslation.ts Outdated Show resolved Hide resolved
...s/components/src/components/PasswordCreationField/lib/getStatusFromPolicyValidationResult.ts Show resolved Hide resolved
...mponents/src/components/PasswordCreationField/lib/getStatusTextFromPolicyValidationResult.ts Outdated Show resolved Hide resolved
@ins0 ins0 temporarily deployed to github-pages-preview January 7, 2025 14:57 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview-storybook January 7, 2025 14:57 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview-storybook January 7, 2025 15:22 — with GitHub Actions Inactive
@ins0 ins0 temporarily deployed to github-pages-preview January 7, 2025 15:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lisa18289 Lisa18289 Lisa18289 left review comments

@mfal mfal mfal approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password component
3 participants
@ins0 @mfal @Lisa18289