Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bulk evaluation signature #107

Merged
merged 6 commits into from
May 17, 2024
Merged

Change bulk evaluation signature #107

merged 6 commits into from
May 17, 2024

Conversation

mkeeter
Copy link
Owner

@mkeeter mkeeter commented May 17, 2024

Changed BulkEvaluator::eval signature to take x, y, z arguments as &[T] instead of &[f32]. This is more flexible for gradient evaluation, because it allows the caller to specify up to three gradients, without pinning them to specific argument.

(this is a building block for eventually decoupling evaluation from specifically requiring(x, y, z) arguments)

@mkeeter mkeeter enabled auto-merge (squash) May 17, 2024 13:31
@mkeeter mkeeter merged commit a3ef12e into main May 17, 2024
11 checks passed
@mkeeter mkeeter deleted the grad-eval branch May 17, 2024 13:36
@mkeeter mkeeter mentioned this pull request May 18, 2024
mkeeter added a commit that referenced this pull request May 18, 2024
This comment was made incorrect by #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant