Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update eframe, image. notify #187

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

waywardmonkeys
Copy link
Collaborator

No description provided.

@waywardmonkeys
Copy link
Collaborator Author

This changes the constraints demo so that it fills the window and is a bit more likely the sample code for eframe. It is kind of janky though when I run it, but it seemed janky before I updated things as well.

@mkeeter
Copy link
Owner

mkeeter commented Nov 16, 2024

The eframe update is unfortunate – previously, the egui demo was constrained to a specific canvas, so it could be embedded into a large webpage (mostly written in normal HTML). The idea here is that I could embed multiple small demos into a blog post; I'd like to keep this property.

(eframe upstream hasn't emphasized this use case, so it's not surprising that they've broken it by accident)

I'd rather leave the eframe dependency as-is, since I don't have time to dig into the internals and figure out what changed. Updating image and notify seems fine to me!

@waywardmonkeys
Copy link
Collaborator Author

If that's important, then I'll look into that.

The updates go well together since they get rid of a few duplicated dependencies, especially on Windows where it gets rid of a whole version of one of the Windows binding crates.

@waywardmonkeys
Copy link
Collaborator Author

Okay, fixed it and will be updating shortly.

@waywardmonkeys
Copy link
Collaborator Author

Your use case was one that they specifically fixed / improved in eframe 0.28!

This updates the constraints demo to work a bit better with egui
in the WebAssembly build.
@waywardmonkeys
Copy link
Collaborator Author

Maybe the last update is better!

@mkeeter
Copy link
Owner

mkeeter commented Nov 16, 2024

Looks good! I restored the outer div to make sure it worked and found that we could minimize the CSS somewhat.

@mkeeter mkeeter enabled auto-merge (squash) November 16, 2024 22:00
@mkeeter mkeeter disabled auto-merge November 16, 2024 22:00
@mkeeter mkeeter enabled auto-merge November 16, 2024 22:00
@mkeeter mkeeter merged commit b467b85 into mkeeter:main Nov 16, 2024
13 checks passed
@waywardmonkeys waywardmonkeys deleted the update-deps branch November 17, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants