Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mobile Touch Events #229

Closed
wants to merge 3 commits into from
Closed

Fix Mobile Touch Events #229

wants to merge 3 commits into from

Conversation

zalo
Copy link
Contributor

@zalo zalo commented Jan 6, 2025

Switches Mouse events for Pointer events, which should automagically make them work on both desktop and mobile browsers.

The rest of the changes are voodoo to prevent the default events browsers associate with dragging, double tapping, and other unsavory touch gestures 💀

@zalo
Copy link
Contributor Author

zalo commented Jan 6, 2025

@mkeeter In-case merely creating the PR did not @ you 😅

zalo added 3 commits January 10, 2025 08:23
Switches `Mouse` events for `Pointer` events, which should automagically make them work on both desktop and mobile browsers.
@mkeeter mkeeter enabled auto-merge (squash) January 10, 2025 13:23
@mkeeter
Copy link
Owner

mkeeter commented Jan 10, 2025

Thanks! At some point, I'd like to get proper multi-finger pan/zoom/tilt working, but this is a good start.

@mkeeter
Copy link
Owner

mkeeter commented Jan 11, 2025

@zalo can you run npm run format to fix CI (in the demos/web-editor/web subfolder)?

@zalo
Copy link
Contributor Author

zalo commented Jan 11, 2025

I’m away for a few days so I can’t fix it myself until Monday maybe 🫠

(I think it’s set that you can make commits to this branch though; do you have a straightforward way to test on mobile?)

(A future PR I might submit is switching to ES Modules and ESBuild, which (in my opinion) is the new “canonical” solution that fixes most of the sins of Webpack, and should make it easier to get up and running with)

(Additionally, I wonder if it makes sense to have a demo integrating with three.js, since that’s closer to the “Unity” of the web… that will yield great multitouch camera controls and a ton of other fun demos when used in conjunction)

@mkeeter mkeeter mentioned this pull request Jan 11, 2025
@mkeeter
Copy link
Owner

mkeeter commented Jan 11, 2025

I'm having trouble with editing this branch, so I'm moving to a new PR #233

@mkeeter mkeeter closed this Jan 11, 2025
auto-merge was automatically disabled January 11, 2025 22:57

Pull request was closed

mkeeter added a commit that referenced this pull request Jan 11, 2025
Ported from #229

---------

Co-authored-by: Johnathon Selstad <makeshifted@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants