-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mobile Touch Events #229
Conversation
@mkeeter In-case merely creating the PR did not @ you 😅 |
Switches `Mouse` events for `Pointer` events, which should automagically make them work on both desktop and mobile browsers.
Thanks! At some point, I'd like to get proper multi-finger pan/zoom/tilt working, but this is a good start. |
@zalo can you run |
I’m away for a few days so I can’t fix it myself until Monday maybe 🫠 (I think it’s set that you can make commits to this branch though; do you have a straightforward way to test on mobile?) (A future PR I might submit is switching to ES Modules and ESBuild, which (in my opinion) is the new “canonical” solution that fixes most of the sins of Webpack, and should make it easier to get up and running with) (Additionally, I wonder if it makes sense to have a demo integrating with three.js, since that’s closer to the “Unity” of the web… that will yield great multitouch camera controls and a ton of other fun demos when used in conjunction) |
I'm having trouble with editing this branch, so I'm moving to a new PR #233 |
Pull request was closed
Ported from #229 --------- Co-authored-by: Johnathon Selstad <makeshifted@gmail.com>
Switches
Mouse
events forPointer
events, which should automagically make them work on both desktop and mobile browsers.The rest of the changes are voodoo to prevent the default events browsers associate with dragging, double tapping, and other unsavory touch gestures 💀