Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86 abs implementation #50

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix x86 abs implementation #50

merged 2 commits into from
Mar 25, 2024

Conversation

mkeeter
Copy link
Owner

@mkeeter mkeeter commented Mar 25, 2024

Previously, we got a zero from a high value in the output XMM register, which isn't actually guaranteed to be empty!

Fixes #47

@mkeeter mkeeter enabled auto-merge (squash) March 25, 2024 00:55
@mkeeter mkeeter merged commit 7bf6f59 into main Mar 25, 2024
4 checks passed
@mkeeter mkeeter deleted the x86-abs-zero branch March 25, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty mesh for JitShape when translating box
1 participant