Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made RenderHandle struct public #99

Closed
wants to merge 1 commit into from

Conversation

LukeP0WERS
Copy link

My project uses a RenderHandle to generate voxels in a way similar to render2d and render3d so it would be helpful if it was public. I also fixed a name conflict that was confusing rust analyzer by renaming the recycle function to recycle_handle

mkeeter added a commit that referenced this pull request May 12, 2024
Same effect as #99 , but with additional cleanup + documentation
@mkeeter
Copy link
Owner

mkeeter commented May 12, 2024

Done in #100, with a few tweaks:

  • Added documentation
  • Made RenderHandle more consistent:
    • All tapes are stored a Arc<..>, so it can be cloned
    • Made construction fully lazy, instead of requiring a value for i_tape

I don't want to rename the recycle function to work around rust-analyzer bugs, because it makes the API less consistent. If you can boil it down to a less-gigantic reproduction case, they'd probably appreciate an upstream issue.

@mkeeter mkeeter closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants