Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually make dask.distributed optional #22 #27

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Conversation

elbdmi
Copy link
Contributor

@elbdmi elbdmi commented Oct 3, 2024

  • Added a check to make psutil and dask.distributed optional to improve flexibility.
  • Introduced a flag (dask_distributed_available) to skip dask-related multiprocessing setup if dependencies are missing.
  • Provided a warning message if dask.distributed or psutil are not available.
  • Updated the code to run only dask-specific logic when the necessary modules are present.

@elbdmi elbdmi self-assigned this Oct 3, 2024
@elbdmi elbdmi requested a review from leifdenby October 3, 2024 11:31
@elbdmi
Copy link
Contributor Author

elbdmi commented Oct 3, 2024

@leifdenby now it is ready

@observingClouds observingClouds mentioned this pull request Oct 3, 2024
Copy link
Member

@leifdenby leifdenby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you for doing this :)

@leifdenby leifdenby merged commit 077faa5 into mllam:main Oct 30, 2024
5 checks passed
This was referenced Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants