-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Learner): support marshal property #993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for learners that e.g. rely on external pointers and that need so processing of the model to be serializable.
Related PR in mlr3torch: |
sebffischer
requested review from
mllg and
be-marc
and removed request for
mllg
January 25, 2024 13:42
be-marc
reviewed
Jan 30, 2024
be-marc
reviewed
Jan 30, 2024
|
sebffischer
changed the title
feat(Learner): support bundling property
feat(Learner): support marshal property
Feb 1, 2024
sebffischer
commented
Feb 1, 2024
sebffischer
commented
Feb 14, 2024
sebffischer
commented
Feb 21, 2024
sebffischer
commented
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion:
benchmark()
orresample()
, the models are in unmarshaled form.$score()
and$aggregate()
it is checked whether the measure needs access to the model, and if so, a good error message is given that informs the user that:a) He needs to
$unmarshal()
the objectb) After doing so, he needs to
$marshal()
again to be able to save the objectTODOs:
clone
/inplace
argument futureverse/marshal#12)Points for discussion:
This is useful for learners that e.g. rely on external pointers and that need processing of the model to be serializable.
Addresses #891
Input checks on the measure (check that model is not marshaleld when accessing the model) only work partially (#1000)
TODOs: