fix: use dev version of tf and make test changes

mlr-org · Jan 2, 2025 · 6d391e1 · 6d391e1
1 parent 2b4e6b0
commit 6d391e1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -33,12 +33,14 @@ Imports:
     mlr3misc (>= 0.14.0),
     paradox,
     R6,
-    tf (>= 0.3.4)
+    tf (>= 0.3.5)
 Suggests:
     rpart,
     tsfeatures,
     testthat (>= 3.0.0),
     withr
+Remotes:
+    tidyfun/tf
 Config/testthat/edition: 3
 Encoding: UTF-8
 LazyData: true

diff --git a/tests/testthat/_snaps/PipeOpFDASmooth.md b/tests/testthat/_snaps/PipeOpFDASmooth.md
@@ -0,0 +1,15 @@
+# PipeOpFDASmooth
+
+    Code
+      train_pipeop(po_smooth, list(task1))
+    Message
+      Using `f = 0.15` as smoother span for "lowess".
+    Output
+      $output
+      <TaskRegr:fuel> (129 x 2): Spectral Data of Fossil Fuels
+      * Target: heatan
+      * Properties: -
+      * Features (1):
+        - tfr (1): NIR
+      
+
diff --git a/tests/testthat/test_PipeOpFDASmooth.R b/tests/testthat/test_PipeOpFDASmooth.R
@@ -50,8 +50,8 @@ test_that("PipeOpFDASmooth", {
   # verbose parameter is respected
   po_smooth = po("fda.smooth")
   po_smooth$param_set$set_values(verbose = TRUE)
-  expect_message(train_pipeop(po_smooth, list(task1)), "using")
+  expect_snapshot(train_pipeop(po_smooth, list(task1)))
   po_smooth = po("fda.smooth")
   po_smooth$param_set$set_values(verbose = FALSE)
-  expect_message(train_pipeop(po_smooth, list(task1)), NA)
+  expect_no_message(train_pipeop(po_smooth, list(task1)))
 })