Add "Copy Current Filter" action

As suggested here: https://forum.shotcut.org/t/copy-single-filters/13909
mltframework · Jan 11, 2025 · a788aef · a788aef
1 parent 6b7de9b
commit a788aef
Show file tree

Hide file tree

Showing 10 changed files with 67 additions and 8 deletions.
diff --git a/icons/dark/32x32/edit-select.png b/icons/dark/32x32/edit-select.png
diff --git a/icons/light/32x32/edit-select.png b/icons/light/32x32/edit-select.png
diff --git a/icons/oxygen/32x32/actions/edit-select.png b/icons/oxygen/32x32/actions/edit-select.png
diff --git a/icons/resources.qrc b/icons/resources.qrc
@@ -227,10 +227,12 @@
         <file>oxygen/32x32/actions/edit-copy.png</file>
         <file>oxygen/32x32/actions/edit-cut.png</file>
         <file>oxygen/32x32/actions/edit-paste.png</file>
+        <file>oxygen/32x32/actions/edit-select.png</file>
         <file>oxygen/32x32/actions/edit-select-all.png</file>
         <file>light/32x32/edit-copy.png</file>
         <file>light/32x32/edit-cut.png</file>
         <file>light/32x32/edit-paste.png</file>
+        <file>light/32x32/edit-select.png</file>
         <file>light/32x32/edit-select-all.png</file>
         <file>oxygen/32x32/actions/format-indent-less.png</file>
         <file>oxygen/32x32/actions/format-indent-more.png</file>
@@ -267,6 +269,7 @@
         <file>dark/32x32/edit-copy.png</file>
         <file>dark/32x32/edit-cut.png</file>
         <file>dark/32x32/edit-paste.png</file>
+        <file>dark/32x32/edit-select.png</file>
         <file>dark/32x32/edit-select-all.png</file>
         <file>dark/32x32/format-indent-less.png</file>
         <file>dark/32x32/format-indent-more.png</file>

diff --git a/src/docks/filtersdock.cpp b/src/docks/filtersdock.cpp
@@ -228,6 +228,17 @@ void FiltersDock::setupActions()
     addAction(action);
     Actions.add("filtersCopyFiltersAction", action, windowTitle());
 
+    action = new QAction(tr("Copy Current Filter"), this);
+    action->setToolTip(tr("Copy current filter to the clipboard"));
+    icon = QIcon::fromTheme("edit-copy",
+                            QIcon(":/icons/oxygen/32x32/actions/edit-select.png"));
+    action->setIcon(icon);
+    connect(action, &QAction::triggered, this, [ = ]() {
+        QmlApplication::singleton().copyCurrentFilter();
+    });
+    addAction(action);
+    Actions.add("filtersCopyCurrentFilterAction", action, windowTitle());
+
     action = new QAction(tr("Paste Filters"), this);
     action->setToolTip(tr("Paste the filters from the clipboard"));
     icon = QIcon::fromTheme("edit-paste",

diff --git a/src/mltcontroller.cpp b/src/mltcontroller.cpp
@@ -1117,13 +1117,14 @@ static int indexOfFirstNonGpu(Producer &toProducer)
 }
 
 void Controller::copyFilters(Producer &fromProducer, Producer &toProducer, bool fromClipboard,
-                             bool includeDisabled)
+                             bool includeDisabled, int filterIndex)
 {
     int in = fromProducer.get(kFilterInProperty) ? fromProducer.get_int(kFilterInProperty) :
              fromProducer.get_in();
     int out = fromProducer.get(kFilterOutProperty) ? fromProducer.get_int(
                   kFilterOutProperty) : fromProducer.get_out();
     int count = fromProducer.filter_count();
+    int filterCount = 0;
 
     // Get the index of the first non-GPU filter or link in toProducer
     int firstNonGpuService = fromClipboard ? indexOfFirstNonGpu(toProducer) : -1;
@@ -1132,8 +1133,16 @@ void Controller::copyFilters(Producer &fromProducer, Producer &toProducer, bool
         QScopedPointer<Mlt::Filter> fromFilter(fromProducer.filter(i));
         if (fromFilter && fromFilter->is_valid() && !fromFilter->get_int("_loader")
                 && !fromFilter->get_int(kShotcutHiddenProperty)
-                && fromFilter->get("mlt_service")
-                && (includeDisabled || !fromFilter->get_int("disable"))) {
+                && fromFilter->get("mlt_service")) {
+
+            filterCount++;
+            if (filterIndex != -1 && filterIndex != (filterCount - 1)) {
+                continue;
+            }
+
+            if (!includeDisabled && fromFilter->get_int("disable")) {
+                continue;
+            }
 
             // Determine if filter can be added
             auto metadata = MAIN.filterController()->metadataForService(fromFilter.data());
@@ -1177,6 +1186,10 @@ void Controller::copyFilters(Producer &fromProducer, Producer &toProducer, bool
             QScopedPointer<Mlt::Link> fromLink(fromChain.link(i));
             if (fromLink && fromLink->is_valid() && fromLink->get("mlt_service")
                     && !fromLink->get_int("_loader")) {
+                filterCount++;
+                if (filterIndex != -1 && filterIndex != (filterCount - 1)) {
+                    continue;
+                }
                 Mlt::Link toLink(fromLink->get("mlt_service"));
                 if (toLink.is_valid()) {
                     toLink.inherit(*fromLink);
@@ -1190,14 +1203,15 @@ void Controller::copyFilters(Producer &fromProducer, Producer &toProducer, bool
     }
 }
 
-void Controller::copyFilters(Mlt::Producer *producer)
+void Controller::copyFilters(Mlt::Producer *producer, int filterIndex)
 {
+    bool includeDisabled = filterIndex >= 0;
     if (producer && producer->is_valid()) {
         initFiltersClipboard();
-        copyFilters(*producer, *m_filtersClipboard, false, false);
+        copyFilters(*producer, *m_filtersClipboard, false, includeDisabled, filterIndex);
     } else if (m_producer && m_producer->is_valid()) {
         initFiltersClipboard();
-        copyFilters(*m_producer, *m_filtersClipboard, false, false);
+        copyFilters(*m_producer, *m_filtersClipboard, false, includeDisabled, filterIndex);
     }
 }
 

diff --git a/src/mltcontroller.h b/src/mltcontroller.h
@@ -130,8 +130,9 @@ class Controller
     void setUuid(Mlt::Properties &properties, QUuid uid) const;
     QUuid ensureHasUuid(Mlt::Properties &properties) const;
     static void copyFilters(Mlt::Producer &fromProducer, Mlt::Producer &toProducer,
-                            bool fromClipboard = false, bool includeDisabled = true);
-    void copyFilters(Mlt::Producer *producer = nullptr);
+                            bool fromClipboard = false, bool includeDisabled = true,
+                            int filterIndex = -1);
+    void copyFilters(Mlt::Producer *producer = nullptr, int filterIndex = -1);
     void pasteFilters(Mlt::Producer *producer = nullptr, Mlt::Producer *fromProducer = nullptr);
     static void adjustFilters(Mlt::Producer &producer, int startIndex = 0);
     static void adjustFilter(Mlt::Filter *filter, int in, int out, int inDelta, int outDelta,

diff --git a/src/qml/views/filter/filterview.qml b/src/qml/views/filter/filterview.qml
@@ -232,6 +232,21 @@ Rectangle {
             }
         }
 
+        Shotcut.Button {
+            id: copySelectedButton
+
+            implicitWidth: height
+            icon.name: 'edit-select'
+            icon.source: 'qrc:///icons/oxygen/32x32/actions/edit-select.png'
+            enabled: selectedIndex > Shotcut.Filter.NoCurrentFilter
+            opacity: enabled ? 1 : 0.5
+            onClicked: application.copyCurrentFilter()
+
+            Shotcut.HoverTip {
+                text: qsTr('Copy current filter')
+            }
+        }
+
         Shotcut.Button {
             id: pasteButton
 

diff --git a/src/qmltypes/qmlapplication.cpp b/src/qmltypes/qmlapplication.cpp
@@ -116,6 +116,20 @@ void QmlApplication::copyFilters()
     emit QmlApplication::singleton().filtersCopied();
 }
 
+void QmlApplication::copyCurrentFilter()
+{
+    int currentIndex = MAIN.filterController()->currentIndex();
+    if (currentIndex < 0) {
+        MAIN.showStatusMessage(tr("Select a filter to copy"));
+        return;
+    }
+    QScopedPointer<Mlt::Producer> producer(new Mlt::Producer(
+                                               MAIN.filterController()->attachedModel()->producer()));
+    MLT.copyFilters(producer.data(), currentIndex);
+    QGuiApplication::clipboard()->setText(MLT.filtersClipboardXML());
+    emit QmlApplication::singleton().filtersCopied();
+}
+
 void QmlApplication::pasteFilters()
 {
     QScopedPointer<Mlt::Producer> producer(new Mlt::Producer(

diff --git a/src/qmltypes/qmlapplication.h b/src/qmltypes/qmlapplication.h
@@ -52,6 +52,7 @@ class QmlApplication : public QObject
     static QRect mainWinRect();
     static bool hasFiltersOnClipboard();
     Q_INVOKABLE static void copyFilters();
+    Q_INVOKABLE static void copyCurrentFilter();
     Q_INVOKABLE static void pasteFilters();
     Q_INVOKABLE static QString clockFromFrames(int frames);
     Q_INVOKABLE static QString timeFromFrames(int frames);