Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds Insights Notification #2244

Merged
merged 16 commits into from
Jan 24, 2025

Conversation

luistak
Copy link

@luistak luistak commented Jan 13, 2025

Allows users to disable insights notifications based on the new Environment Variable

image

Proposed changes

Adds initial Insights helper to manage insights state and notifications

Testing

Issues fixed

luistak and others added 16 commits January 13, 2025 11:20
Allows users to disable insights notification based on the new Environment Variable
* Select web when platform is specified

* Do not log errors on device screen endpoint since this floods the terminal with unnecessary noise when killing studio

* Add url input in studio for web

* Handle openLink without scheme

* Remove comment

* Revert unnecessary change

* Remove unused import
* Fix Windows script error by making classpath shorting using globs

* Update dadb

* Do not use emojis on Windows

* Fix Studio npm builds on Windows

* Make OS comparison case-insensitive

* Use smiley face instead of check

* Use + instead of special char

* Remove debug condition

---------

Co-authored-by: Dan Caseley <dan@caseley.me.uk>
* Remove unused variable in install script

* Remove previous files when installing maestro-cli
@luistak luistak changed the base branch from feat/insights-ai to feat/insights-analyze January 24, 2025 12:07
@luistak luistak merged commit 2546cc3 into feat/insights-analyze Jan 24, 2025
5 checks passed
@luistak luistak deleted the feat/insights-notification branch January 24, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants