Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonZero (new_unchecked) Proof for Contract (Init) #109

Merged
merged 15 commits into from
Nov 11, 2024

Conversation

SahithiMV
Copy link

@SahithiMV SahithiMV commented Oct 9, 2024

Working on #71 (Safety of NonZero)

We are looking for feedback on our proof_for_contract. We have implemented it for all the data types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@SahithiMV SahithiMV requested a review from a team as a code owner October 9, 2024 19:41
library/core/Cargo.toml Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
Corrected issues from Pull Request
Restored previous cargo files
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo these suggestions. Can you please also update your PR description? It says that you only have harnesses for i32, but you have new_unchecked harnesses for all the primitive integer types.

library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Outdated Show resolved Hide resolved
library/core/src/num/nonzero.rs Show resolved Hide resolved
MooniniteErr and others added 6 commits October 27, 2024 14:07
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
@carolynzech carolynzech enabled auto-merge (squash) November 8, 2024 16:53
@carolynzech carolynzech disabled auto-merge November 11, 2024 16:20
@carolynzech carolynzech enabled auto-merge (squash) November 11, 2024 16:25
@carolynzech carolynzech merged commit 0ed4f75 into model-checking:main Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants