Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harnesses for to_bytes and to_bytes_with_nul #189

Merged
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions library/core/src/ffi/c_str.rs
Original file line number Diff line number Diff line change
Expand Up @@ -875,4 +875,42 @@ mod verify {
assert!(c_str.is_safe());
}
}

// pub const fn to_bytes(&self) -> &[u8]
#[kani::proof]
#[kani::unwind(32)]
fn check_to_bytes() {
const MAX_SIZE: usize = 32;
let string: [u8; MAX_SIZE] = kani::any();
let slice = kani::slice::any_slice_of_array(&string);

let result = CStr::from_bytes_until_nul(slice);
if let Ok(c_str) = result {
Yenyun035 marked this conversation as resolved.
Show resolved Hide resolved
// Find the index of the first null byte in the slice since
// from_bytes_until_nul stops by there
let end_idx = slice.iter().position(|x| *x == 0).unwrap();
Yenyun035 marked this conversation as resolved.
Show resolved Hide resolved
// Comparison does not include the null byte
assert_eq!(c_str.to_bytes(), &slice[..end_idx]);
assert!(c_str.is_safe());
}
}

// pub const fn to_bytes_with_nul(&self) -> &[u8]
#[kani::proof]
#[kani::unwind(33)] // 101.7 seconds when 33; 17.9 seconds for 17
fn check_to_bytes_with_nul() {
Yenyun035 marked this conversation as resolved.
Show resolved Hide resolved
const MAX_SIZE: usize = 32;
let string: [u8; MAX_SIZE] = kani::any();
let slice = kani::slice::any_slice_of_array(&string);

let result = CStr::from_bytes_until_nul(slice);
if let Ok(c_str) = result {
// Find the index of the first null byte in the slice since
// from_bytes_until_nul stops by there
let end_idx = slice.iter().position(|x| *x == 0).unwrap();
// Comparison includes the null byte
assert_eq!(c_str.to_bytes_with_nul(), &slice[..end_idx + 1]);
assert!(c_str.is_safe());
}
}
}